Address hitching with GenerateRandomItem #1715
Open
+63
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements GenerateItem which works closely to GenerateRandomItem however doesn't have to do a bunch of lookups for the item allowing the user to directly specify the item name directly
|
Related PR #887 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within gamemodes such as Mann vs. Machine, on a listen server, notable hitching occurs when bots spawn in this is due to GenerateRandomItem which does a big lookup to find the item it wants to spawn. This pull request implements GenerateItem which follows the same rules but avoids the lookup by specifying the name directly which avoids that hitching.