[TF2] fix shortstop shove being prevented by reloading #1719
+52
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
guess i'm blind, looks like there's already an existing pr that i missed: #1420 i'll check that other pr later since there's a bunch of issues i encountered while trying to make this, so that pr would be superior if those issues don't exist since its solution is a lot simpler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes ValveSoftware/Source-1-Games/issues/5326
i think that this can reasonably be considered a bug because the shortstop's alt-fire is the only action in the game that can't interrupt a reload, so i highly doubt that this was intentional at all especially since autoreload is enabled by default
this change allows the secondary fire to cancel a reload in the exact same way the primary fire cancels a reload
(i have also tested this change under high latency conditions)