Repository navigation
feat: support local IPC with direct TCP in reviewer workloads - #2
Merged
Merged
Conversation
Allow filesystem-confined Unix listeners and continue TCP operations without broker threads in the opt-in local IPC mode. Retain Unix connection allowlists and add a real Linux local-service and host-protection check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reviewers need local Unix servers and browser IPC, while ordinary TCP should not allocate a broker thread for every connection. The existing supervisor denies Unix listeners and mediates TCP even when the consumer allows all IP networking.
Changes
Add opt-in
--allow-local-ipcfor filesystem-isolated workloads. Pathname Unix binds and listen operations execute in the workload's mount context, preserving read-only host mounts. TCP/IPv6 operations continue without broker threads or socket duplication. Unix connects retain the path allowlist; abstract binds and Unix datagrams remain denied. This is an accident boundary and deliberately does not protect against concurrent adversarial mutation of syscall arguments.Publish package version
0.0.75-wb.2. The consumer is WillBooster/review-booster issue anthropics#283.Validation
Built static arm64 and x64 binaries with the pinned Zig. A real non-root Linux arm64 workload in a namespace-capable Docker container passed Unix bind/listen/connect, host-local TCP, editable experiment files, denial of unrelated host sockets and host binds, and protected-file checks. The artifact workflow runs the same boundary check on Ubuntu x64. Existing C compiler warnings in the musl CMSG_NXTHDR macro remain unchanged.
Requirements