This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Filter counter in button and tab#2143
Open
obulat wants to merge 10 commits into
Open
Conversation
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/2143 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: +244 B (0%) Total Size: 877 kB
ℹ️ View Unchanged
|
obulat
force-pushed
the
add/filter_count
branch
from
d60d417 to
91a452c
Compare
obulat
added
🟨 priority: medium
obulat
force-pushed
the
fix/content_switcher_tabs
branch
2 times, most recently
from
8bd051e to
fd311d8
Compare
obulat
force-pushed
the
add/filter_count
branch
from
91a452c to
a1ca9df
Compare
obulat
force-pushed
the
fix/content_switcher_tabs
branch
from
fd311d8 to
fb88e76
Compare
obulat
force-pushed
the
add/filter_count
branch
from
9677442 to
375d593
Compare
This is fine. The mix looks strange, but the tab label points out the tab content, in the same way that "Content type" refers to the list of available types of content. |
obulat
force-pushed
the
add/filter_count
branch
from
48d6190 to
c741fd4
Compare
dhruvkb
reviewed
Feb 13, 2023
Member
dhruvkb
left a comment
dhruvkb
left a comment
There was a problem hiding this comment.
What does the component look like with 10 or more filters enabled? Does the number spill out of the bounding box? Should we add VR tests for that case?
|
The counter size and number's font size should allow double digits. Here is a screenshot of how it looks like the Figma component. However, this just works for the Arabic numerals.
|
dhruvkb
approved these changes
Feb 16, 2023
Member
dhruvkb
left a comment
dhruvkb
left a comment
There was a problem hiding this comment.
Approving because the VR tests for 2 digit filters are not blocking. Everything looks good to me!
obulat
force-pushed
the
add/filter_count
branch
from
c741fd4 to
eeec068
Compare
Member
|
@obulat and @panchovm is this the intended styling when the sidebar is open? I find it to be completely illegible with insufficient contrast. |
|
No. The counter has no background when filter is active. Here is a screenshot from the Design Library. Filter, Figma component
Tab, Figma component
|
obulat
force-pushed
the
add/filter_count
branch
2 times, most recently
from
3a49d30 to
1ec6c9a
Compare
obulat
force-pushed
the
add/filter_count
branch
from
1ec6c9a to
4fb8308
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes WordPress/openverse#482 by @panchovm
Description
This PR adds the counter to the filters button and tab according to the Mockups in Figma
@panchovm, I'm not sure about the label when only 1 filter is selected. As you can see here, the label now reads "1 Filters". Should we use parentheses like "1 Filter(s)", change the label according to the number ("Filter" or "Filters"), or is there a better solution?
Edit: reply below (#2143 (comment))
Testing Instructions
Checklist
Update index.md).main) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin