Skip to content

fix: keyboard users can't reach non-link items in the admin bar presence flyout - #275

Merged
josephfusco merged 3 commits into
WordPress:mainfrom
i-am-chitti:fix/keyboard-navigation-264
Aug 14, 2026
Merged

fix: keyboard users can't reach non-link items in the admin bar presence flyout#275
josephfusco merged 3 commits into
WordPress:mainfrom
i-am-chitti:fix/keyboard-navigation-264

Conversation

@i-am-chitti

Copy link
Copy Markdown
Collaborator

Description

Fixes #264

Non-link flyout items (group headers, self row, per-user rows without a screen link) had no tabindex, so Tab skipped them and jumped straight to the last real link.

  • Add meta.tabindex => 0 to every non-link node.
  • Adjust the group-header CSS so focus color is visible instead of being overridden.
  • Add a PHPUnit test asserting every href-less node stays keyboard reachable.

Screencast

screen-recording-2026-08-12-at-104819-pm_KZRy021n.mp4

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Investigating the root cause and drafting the fix.

@github-actions

Copy link
Copy Markdown
Contributor

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props iamchitti, joefusco.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

▶ Preview in WordPress Playground

Open in WordPress Playground

Boots a fresh WordPress with this PR's presence-api build, seeds 5 demo users, and drops you on the dashboard.

Stress-test variant: 40 demo users · Built from 8ff28982e038bdcdc7026d7dab02d58df48a6c0c. Auto-updates when you push.

@i-am-chitti i-am-chitti changed the title Fix: keyboard users can't reach non-link items in the admin bar presence flyout fix: keyboard users can't reach non-link items in the admin bar presence flyout Aug 12, 2026
@josephfusco
josephfusco force-pushed the fix/keyboard-navigation-264 branch from 6ab0d21 to 8ff2898 Compare August 14, 2026 12:33
@josephfusco

Copy link
Copy Markdown
Collaborator

I rebased this to clear the the workflow errors from the 7.0.4 blip.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.89%. Comparing base (1c817f6) to head (8ff2898).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #275      +/-   ##
============================================
+ Coverage     75.87%   75.89%   +0.02%     
  Complexity      176      176              
============================================
  Files            14       14              
  Lines          1832     1842      +10     
============================================
+ Hits           1390     1398       +8     
- Misses          442      444       +2     
Flag Coverage Δ
multisite 75.89% <83.33%> (+0.02%) ⬆️
phpunit 74.59% <83.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@josephfusco josephfusco added [Type] Bug An existing feature is broken [Area] Admin UI Issues for the admin UI integrations php Pull requests that update php code labels Aug 14, 2026

@josephfusco josephfusco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏼

@josephfusco
josephfusco merged commit d73bbf7 into WordPress:main Aug 14, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Admin UI Issues for the admin UI integrations php Pull requests that update php code [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin bar flyout: non-link items unreachable by keyboard

2 participants