Spec: Clarify record-related snapshot summaries refer to physical layout#16005
Open
dannycjones wants to merge 1 commit intoapache:mainfrom
Open
Spec: Clarify record-related snapshot summaries refer to physical layout#16005dannycjones wants to merge 1 commit intoapache:mainfrom
dannycjones wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
the
Specification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor clarification to be clear that the following fields in snapshot summaries refer to the physical layout (i.e. records in data and delete files) rather than logical records (i.e. active records, that should be considered to be valid to return in queries).
It was unclear to me when implementing a compaction algorithm what the values referred to. I have reviewed the Java implementation to confirm that these fields - at least in Java - refer to the physical layout: https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/SnapshotSummary.java#L322-L325.
I acknowledge this is changing the specification (
format/dir) - please let me know if there is a good way to proceed. I'm hoping this is a simple clarification.