Flink 2.1: Fix forward-writer chaining regression in DynamicIcebergSink#16026
Merged
huaxingao merged 1 commit intoapache:mainfrom Apr 19, 2026
Merged
Flink 2.1: Fix forward-writer chaining regression in DynamicIcebergSink#16026huaxingao merged 1 commit intoapache:mainfrom
huaxingao merged 1 commit intoapache:mainfrom
Conversation
Member
|
@drexler-sky Have you rebased on latest main branch? This fix still fails in my local test. |
3 tasks
Contributor
Contributor
|
LGTM, thank you. @manuzhang I cherrypicked this onto main, and verified that this fixed the CI failure. Am I missing something? I ran just the failing test which is |
nssalian
approved these changes
Apr 19, 2026
Contributor
nssalian
left a comment
There was a problem hiding this comment.
Thanks for the prompt fix @drexler-sky. CI run for your PR was clean and I ran this locally to check too after adding your patch:
./gradlew :iceberg-flink:iceberg-flink-2.1:test --tests org.apache.iceberg.flink.sink.dynamic.TestDynamicIcebergSink
and
./gradlew -DsparkVersions= -DkafkaVersions= -DflinkVersions=2.1 :iceberg-flink:iceberg-flink-2.1:check :iceberg-flink:iceberg-flink-runtime-2.1:check -Pquick=true -x javadoc -DtestParallelism=auto
@pvary @stevenzwu PTAL
huaxingao
approved these changes
Apr 19, 2026
Contributor
|
Thanks @drexler-sky for the PR! Thanks everyone for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flink CI failed in the following PRs:
#16006
#16023
#16024
This PR fixes that failure.