Skip to content

Flink 2.1: Fix forward-writer chaining regression in DynamicIcebergSink#16026

Merged
huaxingao merged 1 commit intoapache:mainfrom
drexler-sky:fix_ci
Apr 19, 2026
Merged

Flink 2.1: Fix forward-writer chaining regression in DynamicIcebergSink#16026
huaxingao merged 1 commit intoapache:mainfrom
drexler-sky:fix_ci

Conversation

@drexler-sky
Copy link
Copy Markdown
Contributor

@drexler-sky drexler-sky commented Apr 18, 2026

Flink CI failed in the following PRs:
#16006
#16023
#16024

TestDynamicIcebergSink > testNoShuffleTopology() FAILED
    org.opentest4j.AssertionFailedError: 
    Expecting value to be true but was false
        at app//org.apache.iceberg.flink.sink.dynamic.TestDynamicIcebergSink.testNoShuffleTopology(TestDynamicIcebergSink.java:330)

This PR fixes that failure.

@manuzhang
Copy link
Copy Markdown
Member

@drexler-sky Have you rebased on latest main branch? This fix still fails in my local test.

@huaxingao
Copy link
Copy Markdown
Contributor

cc @pvary @stevenzwu @sachinnn99 @sqd

@sqd
Copy link
Copy Markdown
Contributor

sqd commented Apr 18, 2026

LGTM, thank you. @manuzhang I cherrypicked this onto main, and verified that this fixed the CI failure. Am I missing something? I ran just the failing test which is ./gradlew :iceberg-flink:iceberg-flink-2.1:test --tests org.apache.iceberg.flink.sink.dynamic.TestDynamicIcebergSink

Copy link
Copy Markdown
Contributor

@nssalian nssalian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix @drexler-sky. CI run for your PR was clean and I ran this locally to check too after adding your patch:

./gradlew :iceberg-flink:iceberg-flink-2.1:test --tests org.apache.iceberg.flink.sink.dynamic.TestDynamicIcebergSink

and

./gradlew -DsparkVersions= -DkafkaVersions= -DflinkVersions=2.1 :iceberg-flink:iceberg-flink-2.1:check :iceberg-flink:iceberg-flink-runtime-2.1:check -Pquick=true -x javadoc -DtestParallelism=auto

@pvary @stevenzwu PTAL

@huaxingao huaxingao merged commit f66305a into apache:main Apr 19, 2026
18 checks passed
@huaxingao
Copy link
Copy Markdown
Contributor

huaxingao commented Apr 19, 2026

Thanks @drexler-sky for the PR! Thanks everyone for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants