update faer to 0.23 - #627
Merged
Merged
Conversation
Member
|
Thanks a lot @Ravenslofty ! Since there are so few changes necessary, do you mind adding support for 0.22 as well? What I see missing at first glance is adding checks for the new library versions to the CI pipeline. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 177 177
Lines 20843 20843
=======================================
Hits 19116 19116
Misses 1727 1727 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stefan-k
approved these changes
Oct 2, 2025
stefan-k
left a comment
Member
There was a problem hiding this comment.
Thanks a lot @Ravenslofty ! LGTM :)
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is fortunately much shorter than #575 thanks to the infrastructure introduced there; we can just use the 0.21 backend with the new release.
(too bad I missed the release of 0.11.0)