Skip to content

update faer to 0.23 #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan-k merged 3 commits into from
Oct 2, 2025
Merged

update faer to 0.23 #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55e10bf
update faer to 0.23
Ravenslofty Sep 30, 2025
da704b7
add support for faer 0.22
Ravenslofty Sep 30, 2025
39ffe24
add CI for faer 0.22/0.23
Ravenslofty Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,10 @@ jobs:
# faer
- name: argmin-math (faer_latest)
run: cargo test -p argmin-math --no-default-features --features "faer_latest"
- name: argmin-math (faer_v0_23)
run: cargo test -p argmin-math --no-default-features --features "faer_v0_23"
- name: argmin-math (faer_v0_22)
run: cargo test -p argmin-math --no-default-features --features "faer_v0_22"
- name: argmin-math (faer_v0_21)
run: cargo test -p argmin-math --no-default-features --features "faer_v0_21"
- name: argmin-math (faer_v0_20)
Expand Down
8 changes: 7 additions & 1 deletion crates/argmin-math/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ ndarray_0_13 = { package = "ndarray", version = "0.13", optional = true }
#faer
faer_0_20 = { package = "faer", version = "0.20", optional = true}
faer_0_21 = { package = "faer", version = "0.21", optional = true}
faer_0_22 = { package = "faer", version = "0.22", optional = true}
faer_0_23 = { package = "faer", version = "0.23", optional = true}
faer_traits_0_21 = {package = "faer-traits", version = "0.21", optional = true}
faer_traits_0_22 = {package = "faer-traits", version = "0.22", optional = true}
faer_traits_0_23 = {package = "faer-traits", version = "0.23", optional = true}

# general
num-complex_0_4 = { package = "num-complex", version = "0.4", optional = true, default-features = false, features = ["std"] }
Expand Down Expand Up @@ -80,9 +84,11 @@ ndarray_latest = ["ndarray_v0_16"]

#faer
faer_all = ["primitives"]
faer_latest = ["faer_v0_21"]
faer_latest = ["faer_v0_23"]
faer_v0_20 = ["faer_0_20", "num-complex_0_4", "faer_all"]
faer_v0_21 = ["faer_0_21", "num-complex_0_4", "faer_traits_0_21", "faer_all"]
faer_v0_22 = ["faer_0_22", "num-complex_0_4", "faer_traits_0_22", "faer_all"]
faer_v0_23 = ["faer_0_23", "num-complex_0_4", "faer_traits_0_23", "faer_all"]

## With `ndarray-linalg`
ndarray_v0_16 = ["ndarray_0_16", "ndarray-linalg_0_17", "num-complex_0_4", "ndarray_all"]
Expand Down
4 changes: 4 additions & 0 deletions crates/argmin-math/src/faer_tests/test_helper.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ cfg_if::cfg_if! {
use faer::ComplexField;
} else if #[cfg(feature = "faer_v0_21")] {
use faer_traits::ComplexField;
} else if #[cfg(feature = "faer_v0_22")] {
use faer_traits::ComplexField;
} else if #[cfg(feature = "faer_v0_23")] {
use faer_traits::ComplexField;
}
}

Expand Down
12 changes: 12 additions & 0 deletions crates/argmin-math/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,10 @@ cfg_if::cfg_if! {
extern crate faer_0_20 as faer;
} else if #[cfg(feature = "faer_v0_21")] {
extern crate faer_0_21 as faer;
} else if #[cfg(feature = "faer_v0_22")] {
extern crate faer_0_22 as faer;
} else if #[cfg(feature = "faer_v0_23")] {
extern crate faer_0_23 as faer;
}
}

Expand Down Expand Up @@ -303,6 +307,14 @@ cfg_if! {
extern crate faer_traits_0_21 as faer_traits;
mod faer_m_0_21;
use faer_m_0_21 as faer_m;
} else if #[cfg(feature = "faer_v0_22")] {
extern crate faer_traits_0_22 as faer_traits;
mod faer_m_0_21;
use faer_m_0_21 as faer_m;
} else if #[cfg(feature = "faer_v0_23")] {
extern crate faer_traits_0_23 as faer_traits;
mod faer_m_0_21;
use faer_m_0_21 as faer_m;
}
}

Expand Down
Loading