Remote entity reservation v9

benches/benches/bevy_ecs/world/commands.rs

@@ -92,28 +92,28 @@ pub fn insert_commands(criterion: &mut Criterion) {
             command_queue.apply(&mut world);
         });
     });
-    group.bench_function("insert_or_spawn_batch", |bencher| {
-        let mut world = World::default();
-        let mut command_queue = CommandQueue::default();
-        let mut entities = Vec::new();
-        for _ in 0..entity_count {
-            entities.push(world.spawn_empty().id());
-        }
-
-        bencher.iter(|| {
-            let mut commands = Commands::new(&mut command_queue, &world);
-            let mut values = Vec::with_capacity(entity_count);
-            for entity in &entities {
-                values.push((*entity, (Matrix::default(), Vec3::default())));
-            }
-            #[expect(
-                deprecated,
-                reason = "This needs to be supported for now, and therefore still needs the benchmark."
-            )]
-            commands.insert_or_spawn_batch(values);
-            command_queue.apply(&mut world);
-        });
-    });
+    // group.bench_function("insert_or_spawn_batch", |bencher| {
+    //     let mut world = World::default();
+    //     let mut command_queue = CommandQueue::default();
+    //     let mut entities = Vec::new();
+    //     for _ in 0..entity_count {
+    //         entities.push(world.spawn_empty().id());
+    //     }
+
+    //     bencher.iter(|| {
+    //         let mut commands = Commands::new(&mut command_queue, &world);
+    //         let mut values = Vec::with_capacity(entity_count);
+    //         for entity in &entities {
+    //             values.push((*entity, (Matrix::default(), Vec3::default())));
+    //         }
+    //         #[expect(
+    //             deprecated,
+    //             reason = "This needs to be supported for now, and therefore still needs the benchmark."
+    //         )]
+    //         commands.insert_or_spawn_batch(values);
+    //         command_queue.apply(&mut world);
+    //     });
+    // });
     group.bench_function("insert_batch", |bencher| {
         let mut world = World::default();
         let mut command_queue = CommandQueue::default();

crates/bevy_app/src/sub_app.rs

@@ -142,6 +142,7 @@ impl SubApp {
     /// Runs the default schedule and updates internal component trackers.
     pub fn update(&mut self) {
         self.run_default_schedule();
+        self.world.entities().queue_remote_pending_to_be_flushed();
         self.world.clear_trackers();
     }
 

crates/bevy_ecs/src/archetype.rs

@@ -81,6 +81,11 @@ pub struct ArchetypeId(u32);
 impl ArchetypeId {
     /// The ID for the [`Archetype`] without any components.
     pub const EMPTY: ArchetypeId = ArchetypeId(0);
+    /// This represents an archetype that does not actually exist.
+    /// This can be used as a placeholder.
+    ///
+    /// On an entity, this archetype signals that the entity is not yet part of any archetype.
+    ///
     /// # Safety:
     ///
     /// This must always have an all-1s bit pattern to ensure soundness in fast entity id space allocation.

crates/bevy_ecs/src/bundle.rs

@@ -1420,6 +1420,8 @@ impl<'w> BundleSpawner<'w> {
         table.reserve(additional);
     }
 
+    /// **Note:** This will not cause eny entities to be freed.
+    ///
     /// # Safety
     /// `entity` must be allocated (but non-existent), `T` must match this [`BundleInfo`]'s type
     #[inline]