fix: address sse2neon/streflop macro redefinition warning#2999
Open
bruno-dasilva wants to merge 2 commits into
Open
fix: address sse2neon/streflop macro redefinition warning#2999bruno-dasilva wants to merge 2 commits into
bruno-dasilva wants to merge 2 commits into
Conversation
bruno-dasilva
force-pushed
the
bruno/fix-arm-warnings
branch
from
85fcd22 to
cc24814
Compare
bruno-dasilva
commented
Jun 2, 2026
| #undef FE_TONEAREST | ||
| #undef FE_DOWNWARD | ||
| #undef FE_UPWARD | ||
| #undef FE_TOWARDZERO |
Collaborator
Author
There was a problem hiding this comment.
the warnings emitted were quite spammy:
/build/src/rts/lib/streflop/FPUSettings.h:105:2: warning: #warning STREFLOP: FE_XXX flags were already
defined and will be redefined! Check you do not use the system libm. [-Wcpp]
105 | #warning STREFLOP: FE_XXX flags were already defined and will be redefined! Check you do not use
the system libm.
| ^~~~~~~
Collaborator
There was a problem hiding this comment.
would be good to send a fix (or at least a ticket) upstream to libsse2neon
Collaborator
Author
There was a problem hiding this comment.
created an issue to seek guidance from the devs xref DLTcollab/sse2neon#767
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A separate PR for this arm-setup-specific warning. My understanding is that streflop adds some macros into fenv.h and then sse2neon ALSO creates macros by the same name, causing a warning. The most straightforward way to fix this is we force sse2neon to be truly encapsulated by undef'ing the macros it defines, so the streflop ones still take precedence but without emitting a warning.