Skip to content

fix: address sse2neon/streflop macro redefinition warning #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bruno-dasilva wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: address sse2neon/streflop macro redefinition warning #2999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc24814
fix: address sse2neon/streflop macro redefinition warning
bruno-dasilva Jun 2, 2026
4f25d2a
reword comment
bruno-dasilva Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions rts/System/simd_compat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,19 @@

#ifdef SSE2NEON
#include "lib/sse2neon/sse2neon.h"
// sse2neon leaks <fenv.h>'s FE_XXX macros, which collide with the ones streflop
// redefines and trigger a #warning. Undef them here so streflop gets a clean slate.
#undef FE_INVALID
#undef FE_DENORMAL
#undef FE_DIVBYZERO
#undef FE_OVERFLOW
#undef FE_UNDERFLOW
#undef FE_INEXACT
#undef FE_ALL_EXCEPT
#undef FE_TONEAREST
#undef FE_DOWNWARD
#undef FE_UPWARD
#undef FE_TOWARDZERO

@bruno-dasilva bruno-dasilva Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the warnings emitted were quite spammy:

/build/src/rts/lib/streflop/FPUSettings.h:105:2: warning: #warning STREFLOP: FE_XXX flags were already
  defined and will be redefined! Check you do not use the system libm. [-Wcpp]
    105 | #warning STREFLOP: FE_XXX flags were already defined and will be redefined! Check you do not use
  the system libm.
        |  ^~~~~~~

@sprunk sprunk Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to send a fix (or at least a ticket) upstream to libsse2neon

@bruno-dasilva bruno-dasilva Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created an issue to seek guidance from the devs xref DLTcollab/sse2neon#767

#else
#ifdef _MSC_VER
#include <intrin.h> // MSVC umbrella
Expand Down
Loading