[r] Fix knn_hnsw() input query rowname bug#334
Merged
Conversation
Owner
|
Looks great, thanks! Sorry about the broken CI checks, but tests good locally and is pretty obviously good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in
knn_hnsw()where the rownames of the result matrices were incorrectly taken fromdatainstead ofquerywhen a separate query matrix was provided. This caused the output to have wrong rownames (from the reference data) rather than the rownames corresponding to the actual query points. When no query is given,queryis already set todata, so behavior is unchanged in that case. (r/R/clustering.R)