Skip to content

feat(members): link App bot profile From and Managed by app to App details (slock #14286) - #5134

Closed
stamp-build[bot] wants to merge 4 commits into
mainfrom
agent/reef/129-app-bot-profile-app-link
Closed

stamp-build[bot] wants to merge 4 commits into
mainfrom
agent/reef/129-app-bot-profile-app-link

Conversation

@stamp-build

@stamp-build stamp-build Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Reef from raft opened this pull request through Stamp
View in Stamp →


Port of botiverse/slock #14286 (verified against live botiverse/slock 11504c9eae82d84887b9bc49b1289e9f9317590f) for #wg-mobile-sync:#129:

  • Wire & Model (RaftModels.kt, MemberAgentParser.kt, AgentsApi.kt, DataSnapshots.kt, AgentDetailOffline.kt, MembersStatusFormatting.kt):
    • Decode and carry managedByAppInstallId, managedByApp.clientId (the App row id oauth_clients.id, never public client_id), managedByApp.name, managedByApp.logoUrl, managedByApp.botStatusText, and profileProjection across GET /agents, GET /agents/:id, AgentDetailSummary, offline detail cache, and toStaticMembersProfile.
  • Link Gating & WebView Deep-Link (RaftAppBot.kt, SettingsMarketplacePage.kt, SettingsStandaloneWebViewHost.kt, MembersDetailPage.kt, MembersDetailContent.kt):
    • Added membersManagedAppDetailTarget matching web useManagedAppDetailLink: enabled for non-guest viewers on the bot's own server with a full profile; returns null for guests, unknown role, remote joint-channel bots, bounded channel_summary projections, or missing App row id/name.
    • Added installedAppId (?installed_app=<encodedAppId>) support to SettingsWebViewSurface.Marketplace (openSettingsMarketplacePage, settingsMarketplaceWebViewUrl, settingsWebViewPageData), which opens the installed App's detail dialog in the embedded Apps page (IntegrationsSection / useAppBotLink).
  • App Bot Profile UI (RaftAppBot.kt, MembersAgentProfile.kt, MembersAgentRuntimeConfig.kt):
    • Profile hero "From <logo> <App>" (RaftAppBotFromAppLine) and Info section "Managed by app" row (RaftManagedByAppRowValue, logo + App badge + name, with optional botStatusText below) both render the App icon and open the App's details with accessible label "Open %1$s app details" when eligible, falling back to plain text when not.
    • Hid agent-only Role / Computer / Creator rows for App bots in the Info section (matching web AgentProfileInfo.tsx).
  • i18n: Added member_detail_open_app_details verbatim from live botiverse/slock across all 8 locales (values/, zh-rCN, ja, zh-rTW, ko, es, pt-rBR, ru).
  • Tests & Changeset: Added ManagedAppDetailLinkTest, AgentsApiTest, and SettingsMarketplaceWebViewTest coverage, plus change-logs/1.28.0/changesets/app-bot-profile-app-link.md (zh-CN / en / ja).

Validation

  • Local lightweight checks: git diff --check, scripts/ci/check_source_constraints.py, scripts/ci/check_string_edge_spaces.py, and 8-locale XML parity passed.
  • Compile & tests: running on hosted CI (Test workflow; iOS compile runs on merge queue).

@stamp-build

stamp-build Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

Merged by Stamp in batch 6a2458c9389667280f1501268968583f: c78a6a1 . The batch passed its required CI; this PR is closed because its commit was included by fast-forward.

Review in stamp.build

@stamp-build stamp-build Bot closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants