Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions change-logs/1.28.0/changesets/app-bot-profile-app-link.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
type: improved
area: members
platforms:
- android
- ios
- desktop
pull_request: 5134
rollout: full
---

## zh-CN
- 在应用机器人的资料页中,「来自」和「所属应用」现在会显示应用图标,点击后可直接打开该应用的详情页。

## en
- On an App bot's profile, "From" and "Managed by app" now show the App's icon and open the App's details when tapped.

## ja
- アプリボットのプロフィールで「提供元」と「管理元アプリ」にアプリアイコンが表示され、タップするとアプリの詳細を開けるようになりました。
Original file line number Diff line number Diff line change
Expand Up @@ -1771,6 +1771,7 @@
<string name="member_label_app_with_app">App · %1$s</string>
<string name="member_label_app_tooltip">Creado por la app %1$s</string>
<string name="member_label_app_from_app">De %1$s</string>
<string name="member_detail_open_app_details">Abrir los detalles de la app %1$s</string>
<string name="profile_preview_unavailable">Perfil no disponible</string>
<string name="profile_preview_view_profile">Ver perfil</string>
<string name="profile_preview_managed_by_app">Administrado por la app</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1774,6 +1774,7 @@
<string name="member_label_app_with_app">アプリ · %1$s</string>
<string name="member_label_app_tooltip">%1$s アプリが作成</string>
<string name="member_label_app_from_app">提供元: %1$s</string>
<string name="member_detail_open_app_details">%1$s アプリの詳細を開く</string>
<string name="profile_preview_unavailable">プロフィールを表示できません</string>
<string name="profile_preview_view_profile">プロフィールを表示</string>
<string name="profile_preview_managed_by_app">管理元アプリ</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1771,6 +1771,7 @@
<string name="member_label_app_with_app">앱 · %1$s</string>
<string name="member_label_app_tooltip">%1$s 앱이 만듦</string>
<string name="member_label_app_from_app">제공: %1$s</string>
<string name="member_detail_open_app_details">%1$s 앱 세부 정보 열기</string>
<string name="profile_preview_unavailable">프로필을 볼 수 없어요</string>
<string name="profile_preview_view_profile">프로필 보기</string>
<string name="profile_preview_managed_by_app">관리 앱</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1771,6 +1771,7 @@
<string name="member_label_app_with_app">App · %1$s</string>
<string name="member_label_app_tooltip">Criado pelo app %1$s</string>
<string name="member_label_app_from_app">De %1$s</string>
<string name="member_detail_open_app_details">Abrir os detalhes do app %1$s</string>
<string name="profile_preview_unavailable">Perfil indisponível</string>
<string name="profile_preview_view_profile">Ver perfil</string>
<string name="profile_preview_managed_by_app">Gerenciado pelo app</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1771,6 +1771,7 @@
<string name="member_label_app_with_app">Приложение · %1$s</string>
<string name="member_label_app_tooltip">Создан приложением %1$s</string>
<string name="member_label_app_from_app">Из приложения %1$s</string>
<string name="member_detail_open_app_details">Открыть сведения о приложении %1$s</string>
<string name="profile_preview_unavailable">Профиль недоступен</string>
<string name="profile_preview_view_profile">Открыть профиль</string>
<string name="profile_preview_managed_by_app">Управляется приложением</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1772,6 +1772,7 @@
<string name="member_label_app_with_app">应用 · %1$s</string>
<string name="member_label_app_tooltip">由 %1$s 应用创建</string>
<string name="member_label_app_from_app">来自 %1$s</string>
<string name="member_detail_open_app_details">打开 %1$s 应用详情</string>
<string name="profile_preview_unavailable">资料不可用</string>
<string name="profile_preview_view_profile">查看资料</string>
<string name="profile_preview_managed_by_app">所属应用</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1771,6 +1771,7 @@
<string name="member_label_app_with_app">應用程式 · %1$s</string>
<string name="member_label_app_tooltip">由 %1$s 應用程式建立</string>
<string name="member_label_app_from_app">來自 %1$s</string>
<string name="member_detail_open_app_details">開啟 %1$s 應用程式詳細資料</string>
<string name="profile_preview_unavailable">無法顯示個人檔案</string>
<string name="profile_preview_view_profile">查看資料</string>
<string name="profile_preview_managed_by_app">所屬應用程式</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1775,6 +1775,7 @@
<string name="member_label_app_with_app">App · %1$s</string>
<string name="member_label_app_tooltip">Created by the %1$s app</string>
<string name="member_label_app_from_app">From %1$s</string>
<string name="member_detail_open_app_details">Open %1$s app details</string>
<string name="profile_preview_unavailable">Profile unavailable</string>
<string name="profile_preview_view_profile">View Profile</string>
<string name="profile_preview_managed_by_app">Managed by app</string>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,13 @@ internal data class StoredAgentSummary(
val createdAgents: List<StoredAgentCreated> = emptyList(),
val deletedAt: String? = null,
val lastSeenAt: String? = null,
val hostedRuntime: AgentHostedRuntimeSnapshot? = null
val hostedRuntime: AgentHostedRuntimeSnapshot? = null,
val managedByAppInstallId: String? = null,
val managedByAppClientId: String? = null,
val managedByAppName: String? = null,
val managedByAppLogoUrl: String? = null,
val managedByAppBotStatusText: String? = null,
val profileProjection: String? = null
)

@Serializable
Expand Down Expand Up @@ -292,6 +298,12 @@ private fun AgentDetailSummary.toStored(): StoredAgentSummary =
createdAgents.map { StoredAgentCreated(it.id, it.name, it.displayName, it.avatarUrl, it.runtime, it.status, it.isExternal) },
deletedAt = deletedAt,
lastSeenAt = lastSeenAt,
managedByAppInstallId = managedByAppInstallId,
managedByAppClientId = managedByAppClientId,
managedByAppName = managedByAppName,
managedByAppLogoUrl = managedByAppLogoUrl,
managedByAppBotStatusText = managedByAppBotStatusText,
profileProjection = profileProjection,
)

/** The stored record as a cached detail (a read-only stand-in: the page grants no edits from the cache). */
Expand Down Expand Up @@ -334,6 +346,12 @@ internal fun StoredAgentDetail.toCachedAgentDetail(): RaftCachedAgentDetail {
},
deletedAt = it.deletedAt,
lastSeenAt = it.lastSeenAt,
managedByAppInstallId = it.managedByAppInstallId,
managedByAppClientId = it.managedByAppClientId,
managedByAppName = it.managedByAppName,
managedByAppLogoUrl = it.managedByAppLogoUrl,
managedByAppBotStatusText = it.managedByAppBotStatusText,
profileProjection = it.profileProjection,
)
},
directMessages =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,18 @@ internal data class AgentSummary(
val deletedAt: String?,
/** A personal assistant's owner (`assistantOwnerUserId`); null for a shared agent. */
val assistantOwnerUserId: String? = null,
/** App Bots only (`agents.managedByAppInstallId`); null for ordinary agents and guest projections. */
val managedByAppInstallId: String? = null,
/** App Bots only: owning App row id (`managedByApp.clientId` = `oauth_clients.id`, slock #14286). */
val managedByAppClientId: String? = null,
/** App Bots only: owning App display name (`managedByApp.name`). */
val managedByAppName: String? = null,
/** App Bots only: owning App logo URL (`managedByApp.logoUrl`). */
val managedByAppLogoUrl: String? = null,
/** App Bots only: app-published status line (`managedByApp.botStatusText`). */
val managedByAppBotStatusText: String? = null,
/** Bounded public profile projection marker (`"channel_summary"`, `routes/agents.ts`). */
val profileProjection: String? = null,
/** Web parity: `agent.external === true || runtime === "external"`. */
val isExternal: Boolean = false,
/** External agents only: `lastSeenAt` from `GET /agents*` (`agent:seen` updates it in the store). */
Expand Down Expand Up @@ -867,6 +879,12 @@ internal fun AgentSummary.toAgentDetailSummary(): AgentDetailSummary =
activityDetail = activityDetail,
deletedAt = deletedAt,
assistantOwnerUserId = assistantOwnerUserId,
managedByAppInstallId = managedByAppInstallId,
managedByAppClientId = managedByAppClientId,
managedByAppName = managedByAppName,
managedByAppLogoUrl = managedByAppLogoUrl,
managedByAppBotStatusText = managedByAppBotStatusText,
profileProjection = profileProjection,
lastSeenAt = lastSeenAt,
activityDetailKind = activityDetailKind,
wakeCrashLoop = wakeCrashLoop,
Expand Down Expand Up @@ -1106,6 +1124,12 @@ private data class AgentWireDto(
val deletedAt: String? = null,
/** Personal assistant (botiverse/slock packages/shared agent `assistantOwnerUserId`): its owner, else null. */
val assistantOwnerUserId: String? = null,
/** App Bots only (`routes/agents.ts` `managedByAppInstallId`). */
val managedByAppInstallId: String? = null,
/** App Bots only (`routes/agents.ts` `managedByApp`: `{ clientId, name, logoUrl, description, botStatusText }`). */
val managedByApp: AgentManagedByAppWireDto? = null,
/** Bounded public projection marker (`routes/agents.ts` `"channel_summary"`). */
val profileProjection: String? = null,
/**
* External agents only: ISO-8601 `lastSeenAt` from `GET /agents*` — last
* credential use; presence derives from it (`agent:seen` supersedes).
Expand Down Expand Up @@ -1138,6 +1162,15 @@ private data class AgentWireDto(
val hostedRuntime: AgentHostedRuntimeWireDto? = null
)

@Serializable
private data class AgentManagedByAppWireDto(
val clientId: String? = null,
val name: String? = null,
val logoUrl: String? = null,
val description: String? = null,
val botStatusText: String? = null,
)

@Serializable
private data class AgentModelLimitsWireDto(
val defaultsReported: Boolean? = null,
Expand Down Expand Up @@ -1216,6 +1249,12 @@ private fun AgentWireDto.toSummary(): AgentSummary? {
activityDetail = activityDetail,
deletedAt = deletedAt,
assistantOwnerUserId = assistantOwnerUserId?.takeIf { it.isNotBlank() },
managedByAppInstallId = managedByAppInstallId?.trim()?.takeIf { it.isNotBlank() },
managedByAppClientId = managedByApp?.clientId?.trim()?.takeIf { it.isNotBlank() },
managedByAppName = managedByApp?.name?.trim()?.takeIf { it.isNotBlank() },
managedByAppLogoUrl = managedByApp?.logoUrl?.trim()?.takeIf { it.isNotBlank() },
managedByAppBotStatusText = managedByApp?.botStatusText?.trim()?.takeIf { it.isNotBlank() },
profileProjection = profileProjection?.trim()?.takeIf { it.isNotBlank() },
lastSeenAt = lastSeenAt?.takeIf { it.isNotBlank() },
activityDetailKind = activityDetailKind?.trim()?.takeIf { it.isNotEmpty() },
wakeCrashLoop = wakeCrashLoop.toAgentWakeCrashLoop(activityDetailKind),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,18 @@ data class AgentDetailSummary(
val deletedAt: String? = null,
/** A personal assistant's owner; null for a shared agent (Agent Lounge v0 hides the Lounge for it). */
val assistantOwnerUserId: String? = null,
/** App Bots only (`agents.managedByAppInstallId`); null for ordinary agents and guest projections. */
val managedByAppInstallId: String? = null,
/** App Bots only: owning App row id (`managedByApp.clientId` = `oauth_clients.id`, slock #14286). */
val managedByAppClientId: String? = null,
/** App Bots only: owning App display name (`managedByApp.name`). */
val managedByAppName: String? = null,
/** App Bots only: owning App logo URL (`managedByApp.logoUrl`). */
val managedByAppLogoUrl: String? = null,
/** App Bots only: app-published status line (`managedByApp.botStatusText`). */
val managedByAppBotStatusText: String? = null,
/** Bounded public profile projection marker (`"channel_summary"`, `routes/agents.ts`). */
val profileProjection: String? = null,
/** External agents only: `lastSeenAt` — credential last-use; realtime `agent:seen` advances it (task #410). */
val lastSeenAt: String? = null,
/** The typed kind behind [activityDetail] (`activityDetailKind`); null from older servers. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,8 @@ private data class WireAgent(
* `computer_version_unsupported`; null otherwise. Additive: an unknown value is kept raw.
*/
val blockedReason: String? = null,
/** Bounded public projection marker (`"channel_summary"`, `routes/agents.ts`). */
val profileProjection: String? = null,
)

/** slock `projectAssistantPause` `assistantPausedBy`: `{ id, name }`. */
Expand All @@ -210,6 +212,8 @@ private data class WireManagedByApp(
val clientId: String? = null,
val name: String? = null,
val logoUrl: String? = null,
val description: String? = null,
val botStatusText: String? = null,
)

@Serializable
Expand Down Expand Up @@ -1034,7 +1038,11 @@ private fun WireAgent.toMemberProfile(): MemberProfile {
assistantOwnerUserId = assistantOwnerUserId?.trim()?.takeIf { it.isNotEmpty() },
managedByAppInstallId = managedByAppInstallId?.takeIf { it.isNotBlank() },
agentCreatorUserId = creatorId?.trim()?.takeIf { it.isNotEmpty() && creatorType == "user" },
managedByAppClientId = managedByApp?.clientId?.trim()?.takeIf { it.isNotBlank() },
managedByAppName = managedByApp?.name?.takeIf { it.isNotBlank() },
managedByAppLogoUrl = managedByApp?.logoUrl?.trim()?.takeIf { it.isNotBlank() },
managedByAppBotStatusText = managedByApp?.botStatusText?.trim()?.takeIf { it.isNotBlank() },
profileProjection = profileProjection?.trim()?.takeIf { it.isNotBlank() },
inMemberLists = inMemberLists,
model = firstNonBlank(model, runtimeProfile?.current?.model),
permissionBadges = listOfNotNull(
Expand Down
Loading
Loading