Skip to content

test(designsystem): drop legacy screenshot tests replaced by vcase - #5162

Merged
stamp-build[bot] merged 2 commits into
mainfrom
agent/sindresorhus/vcase-drop-legacy
Nov 20, 2026
Merged

stamp-build[bot] merged 2 commits into
mainfrom
agent/sindresorhus/vcase-drop-legacy

Conversation

@stamp-build

@stamp-build stamp-build Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

sindresorhus from raft opened this pull request through Stamp
View in Stamp →


Follow-up to #5140 (vcase pilot, Raft #proj-mobile:#211).

The pilot recorded vcase goldens for the empty state, save status and composer drop overlay galleries, and LegacyGoldenParityTest confirmed they equal the legacy RaftScreenshot goldens pixel for pixel. As agreed in the pilot review, this removes:

  • EmptyStateScreenshotTest, SaveStatusScreenshotTest, ComposerDropOverlayScreenshotTest
  • their six legacy goldens (*_light.png / *_dark.png)
  • LegacyGoldenParityTest (one-off migration gate)

Test-only; no app behaviour change. Coverage stays the same through the @VCase cases and screenshots/vcase/desktop-skiko/.

sindresorhus added 2 commits November 20, 2026 11:49
The vcase pilot (#5140) recorded goldens for empty state, save status and
the composer drop overlay that matched the legacy RaftScreenshot goldens
pixel for pixel. Remove the three legacy gallery tests, their six goldens
and the one-off LegacyGoldenParityTest migration gate.

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
@stamp-build
stamp-build Bot merged commit 647b6de into main Nov 20, 2026
11 checks passed
@stamp-build

stamp-build Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

New failure in post-merge full tests: workflow Test on branch main after PR 5162 merged.

Newly failing:

  • iOS compile
  • CI gate

It could be any of PR 5160, PR 5162, PR 5164, PR 5165, PR 5167, PR 5170, PR 5171.

Please fix. See logs: stamp run view 44789067976 --repo botiverse/mobile --log-failed

stamp-build Bot added a commit that referenced this pull request Nov 20, 2026
…5176)

* test(designsystem): vcase cases for eight more gallery screenshot tests

Second vcase batch, after the pilot (#5140, #5162). Each case copies its
legacy RaftScreenshot test's content; the legacy tests and goldens stay
until LegacyGoldenParityTest (re-introduced for this batch) shows the
recorded vcase goldens equal them pixel for pixel.

- TextFieldContainerAddon: ds.text-field-container-addon.gallery
- MessageEmbed: ds.message-embed.gallery
- TaskCompactList: ds.task-compact-list.gallery
- ModeBar: ds.mode-bar.gallery
- SelectionToolbar: ds.selection-toolbar.gallery, .fit, .dock
- TaskHeadComponents: ds.description-list.inline, ds.timeline.gallery
- PullDownPanel: ds.pull-down-panel.default
- MessageAttachmentCard: ds.message-attachment-card.gallery

vcase 0.1.0 -> 0.1.1 (a case that only moved within its file is a
note, not a manifest failure).

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>

* test(designsystem): vcase goldens for batch 2 (recorded on CI run 44810868569)

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>

---------

Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Co-authored-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
@stamp-build

stamp-build Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor Author

New failure in post-merge full tests: workflow App link diagnose on branch main after PR 5162 merged.

Newly failing:

  • Report (possibly flaky)

It could be any of PR 5160, PR 5162, PR 5164, PR 5165, PR 5167, PR 5168, PR 5169, PR 5170 and 14 more.

Please fix. See logs: stamp run view 44849680002 --repo botiverse/mobile --log-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants