Repository navigation
test(designsystem): drop legacy screenshot tests replaced by vcase - #5162
Merged
Merged
Conversation
added 2 commits
November 20, 2026 11:49
The vcase pilot (#5140) recorded goldens for empty state, save status and the composer drop overlay that matched the legacy RaftScreenshot goldens pixel for pixel. Remove the three legacy gallery tests, their six goldens and the one-off LegacyGoldenParityTest migration gate. Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Contributor
Author
|
New failure in post-merge full tests: workflow Newly failing:
It could be any of PR 5160, PR 5162, PR 5164, PR 5165, PR 5167, PR 5170, PR 5171. Please fix. See logs: |
stamp-build Bot
added a commit
that referenced
this pull request
Nov 20, 2026
…5176) * test(designsystem): vcase cases for eight more gallery screenshot tests Second vcase batch, after the pilot (#5140, #5162). Each case copies its legacy RaftScreenshot test's content; the legacy tests and goldens stay until LegacyGoldenParityTest (re-introduced for this batch) shows the recorded vcase goldens equal them pixel for pixel. - TextFieldContainerAddon: ds.text-field-container-addon.gallery - MessageEmbed: ds.message-embed.gallery - TaskCompactList: ds.task-compact-list.gallery - ModeBar: ds.mode-bar.gallery - SelectionToolbar: ds.selection-toolbar.gallery, .fit, .dock - TaskHeadComponents: ds.description-list.inline, ds.timeline.gallery - PullDownPanel: ds.pull-down-panel.default - MessageAttachmentCard: ds.message-attachment-card.gallery vcase 0.1.0 -> 0.1.1 (a case that only moved within its file is a note, not a manifest failure). Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> * test(designsystem): vcase goldens for batch 2 (recorded on CI run 44810868569) Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> --------- Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> Co-authored-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Contributor
Author
|
New failure in post-merge full tests: workflow Newly failing:
It could be any of PR 5160, PR 5162, PR 5164, PR 5165, PR 5167, PR 5168, PR 5169, PR 5170 and 14 more. Please fix. See logs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5140 (vcase pilot, Raft #proj-mobile:#211).
The pilot recorded vcase goldens for the empty state, save status and composer drop overlay galleries, and LegacyGoldenParityTest confirmed they equal the legacy RaftScreenshot goldens pixel for pixel. As agreed in the pilot review, this removes:
*_light.png/*_dark.png)Test-only; no app behaviour change. Coverage stays the same through the
@VCasecases andscreenshots/vcase/desktop-skiko/.