Repository navigation
test(designsystem): vcase batch 2 (8 gallery tests as @VCase cases) - #5176
Merged
Merged
Conversation
added 2 commits
November 20, 2026 19:54
Second vcase batch, after the pilot (#5140, #5162). Each case copies its legacy RaftScreenshot test's content; the legacy tests and goldens stay until LegacyGoldenParityTest (re-introduced for this batch) shows the recorded vcase goldens equal them pixel for pixel. - TextFieldContainerAddon: ds.text-field-container-addon.gallery - MessageEmbed: ds.message-embed.gallery - TaskCompactList: ds.task-compact-list.gallery - ModeBar: ds.mode-bar.gallery - SelectionToolbar: ds.selection-toolbar.gallery, .fit, .dock - TaskHeadComponents: ds.description-list.inline, ds.timeline.gallery - PullDownPanel: ds.pull-down-panel.default - MessageAttachmentCard: ds.message-attachment-card.gallery vcase 0.1.0 -> 0.1.1 (a case that only moved within its file is a note, not a manifest failure). Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
…10868569) Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
stamp-build Bot
added a commit
that referenced
this pull request
Nov 20, 2026
…replaced (#5178) #5176 recorded vcase goldens for these galleries; all 22 are pixel-identical to the legacy RaftScreenshot goldens. Remove the legacy tests, their goldens and the temporary LegacyGoldenParityTest. Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> Co-authored-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Contributor
Author
|
New failure in post-merge full tests: workflow Newly failing:
It could be any of PR 5160, PR 5162, PR 5164, PR 5165, PR 5167, PR 5168, PR 5169, PR 5170 and 14 more. Please fix. See logs: |
stamp-build Bot
added a commit
that referenced
this pull request
Nov 21, 2026
…wide/fine/settle/maxWidth) (#5223) * test(designsystem): vcase batch 3 (13 gallery tests as @vcase cases) Third vcase batch, after #5176. Each case copies its legacy RaftScreenshot test's content; the legacy tests and goldens stay until LegacyGoldenParityTest (re-introduced for this batch) shows the recorded vcase goldens equal them pixel for pixel. vcase 0.1.1 -> 0.1.2 for the capture settings these tests need: @vcase(maxWidth) for galleries wider than 1200dp, settleFrames with frameIntervalMs = 0 (RaftScreenshot's settle frames, every frame at time 0), and viewport size classes. RaftVCaseHost gains an opt-in `wide` viewport (same 1200 x 2400 bounds, sizeClass wide) that pins RaftScale.Wide; the pointer axis already maps to RaftPointerInput. Wider than 1200dp: - ChoiceList: ds.choice-list.gallery, .grouped, .multiple (1600) - ChoicePicker: ds.choice-picker.gallery, .grouped (1400) - Combobox: ds.combobox.trigger, .sheet (1600), .list - ThemeDecor: ds.theme-decor.top, .top-actions (1340, 2 settle), .rail Wide scale and the fine pointer: - DesktopScale: ds.desktop-scale.gallery (wide; fine and touch) - FitToolbar: ds.fit-toolbar.members, .members-fine (wide, fine), .filters, .filters-end-view - PointerDensity: ds.pointer-density.controls, .heads (2 settle), .rail (wide, fine) - SidebarSectionMouse: ds.sidebar-section.mouse (fine, 2 settle) Settle frames: - FrameInsets: ds.frame-insets.tooltip - ToastHost: ds.toast-host.gallery - PreviewCard: ds.preview-card.open, .item - MessageReaction: ds.message-reaction.gallery, .tooltip, ds.message-replies.gallery - AppRail: ds.app-rail.gallery, .tooltip, .footer-toggle, .compact Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> * test(designsystem): vcase goldens for batch 3 (recorded on CI run 44878614709) 64 vcase goldens, each pixel-identical to the legacy golden it replaces (LegacyGoldenParityTest). Nine legacy goldens are re-recorded with them: choice_picker_grouped, theme_decor_top_actions, fit_toolbar_filters and fit_toolbar_filters_end_view (light and dark), and combobox_trigger_dark. They had drifted from what RaftScreenshot renders today, by less than its tolerance (so the legacy tests still passed): the agent avatar's edge, sheet separator ends, the filter row's end fade, and colour steps of 1 to 3. Re-recorded by the legacy harness itself (the old files removed so Roborazzi wrote them anew), the fresh legacy renders equal the vcase renders byte for byte. Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> --------- Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build> Co-authored-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raft #proj-mobile:#211, vcase phase 1 batch 2. Same pattern as the pilot (#5140 → #5162).
@VCasecases (11 cases, light/dark): text field container addon, message embed, task compact list, mode bar, selection toolbar (gallery/fit/dock), description list inline + timeline (task head), pull-down panel, message attachment card.screenshots/vcase/desktop-skiko/; manifest updated.LegacyGoldenParityTestis back: each new golden must equal its legacy RaftScreenshot golden pixel for pixel. When green, a follow-up PR deletes the 8 legacy tests, their 22 goldens and the parity test.Skipped for now (capture options vcase cannot reproduce exactly yet): ChoiceList, ChoicePicker, Combobox (max width > 1200), PreviewCard, ToastHost, MessageReaction, ThemeDecor (settleFrames=2), FitToolbar (wide scale + fine pointer).
Test-only; no app behaviour change.