Fix lazy loading when using pathlib.Path and resolve test failures#347
Merged
dschwoerer merged 14 commits intomasterfrom Apr 28, 2026
Merged
Fix lazy loading when using pathlib.Path and resolve test failures#347dschwoerer merged 14 commits intomasterfrom
dschwoerer merged 14 commits intomasterfrom
Conversation
The path check assumed the path was a string, which would make the dataset load in a non-lazy way if the path was pathlib.Path
The "squashed" dataset is quite different from a real, squashed dataset. Likely a real one would not work either.
Not doing results in random warnings of unclosed files, and might also cause dead-locks
Contributor
Author
|
I think this is the summary of the relevant changes:
This should further align lazy_load to the legacy load where reasonable possible, and give a clear error where not. |
mikekryjak
approved these changes
Apr 28, 2026
Collaborator
mikekryjak
left a comment
mikekryjak
left a comment
There was a problem hiding this comment.
Excellent work, @dschwoerer. I appreciate it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.