fix(server/state): scope our access to the client properly to prevent deadlock#4008
Open
AvarianKnight wants to merge 1 commit into
Open
fix(server/state): scope our access to the client properly to prevent deadlock#4008AvarianKnight wants to merge 1 commit into
AvarianKnight wants to merge 1 commit into
Conversation
… deadlock If you listened to onPlayerBucketChange you would deadlock if you called GetPlayerRoutingBucket, while someone shouldn't do this since the argument is already provided in the event, we should also not deadlock.
github-actions
Bot
added
the
invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you listened to onPlayerBucketChange you would deadlock if you called GetPlayerRoutingBucket, while someone shouldn't do this since the argument is already provided in the event, we should also not deadlock.
This PR applies to the following area(s)
Server
Successfully tested on
Game builds: ..
Platforms: Windows, Linux
Checklist
Fixes issues