-
Notifications
You must be signed in to change notification settings - Fork 5
feat(sonarqube): make admin group path configurable though console #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🤖 Hey ! The @cpn-console/hooks (v4.0.0) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/keycloak-plugin (v2.1.0) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/sonarqube-plugin (v2.0.5) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/shared (v1.3.0) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/gitlab-plugin (v3.3.1) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
2f6f9b7 to
a123c81
Compare
5468a36 to
f12d4db
Compare
| .filter((g): g is string => !!g) | ||
|
|
||
| // Sync Roles | ||
| for (const roleGroup of allRoleGroups) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Il va nous falloir quelques tests auto pour documenter/valider ces invariants.
|
d2b890b to
2fc246e
Compare
2df3a80 to
02c0507
Compare
For some reasons, the config is never passed down to the plugins hooks. Apparently the config is provided via the adminPlugin table of the database but is empty most of the time so for the moment let's just add default and fix the problem properly later. Signed-off-by: William Phetsinorath <[email protected]>
67d3b9b to
9580fc5
Compare
We don't want drift to be an option in the future, so we'll keep the purge option as an admin only. Signed-off-by: William Phetsinorath <[email protected]>
Signed-off-by: William Phetsinorath <[email protected]>
Signed-off-by: William Phetsinorath <[email protected]>

2 New Issues
2 Fixed Issues
0 Accepted Issues
Signed-off-by: William Phetsinorath [email protected]
Stack created with Sapling. Best reviewed with ReviewStack.