Skip to content

feat(keycloack): add configurable purge at upsert#1907

Merged
shikanime merged 4 commits intomainfrom
pr1907
Feb 10, 2026
Merged

feat(keycloack): add configurable purge at upsert#1907
shikanime merged 4 commits intomainfrom
pr1907

Conversation

…loack

The new AdminRole implementation introduced by #1893 changed the source of truth from Keycloak to Console, which overrides all existing data based on the state of Console.

Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
@shikanime shikanime force-pushed the pr1907 branch 3 times, most recently from 6d89d17 to d06e5aa Compare February 9, 2026 14:28
@shikanime shikanime marked this pull request as ready for review February 9, 2026 14:30
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

🤖 Hey !

The @cpn-console/shared (v1.3.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

🤖 Hey !

The @cpn-console/keycloak-plugin (v2.1.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

🤖 Hey !

The @cpn-console/hooks (v4.0.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions github-actions bot added the built label Feb 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime force-pushed the pr1907 branch 3 times, most recently from 471d473 to 35e4961 Compare February 9, 2026 15:24
The implementation of ProjectRole is slightly different from AdminRole in which the members are stored around Project struture. I didn't took account of this difference in #1880 and #1879 leading to member addition to never materialize.

Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
@cloud-pi-native-sonarqube
Copy link

.filter((g): g is string => !!g)

// Sync Roles
for (const roleGroup of allRoleGroups) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On doit voir comment test en e2e

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shikanime shikanime merged commit f8fb77d into main Feb 10, 2026
68 checks passed
@shikanime shikanime deleted the pr1907 branch February 10, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants