Repository navigation
🤖 ci: keep stderr out of the cold-start JSON artifact - #6000
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The desktop cold-start job from #5997 uploads a
cold-start.jsonthat is not valid JSON. This PR moves the stdout redirect insidesh -c, so only the runner's JSON reaches the file. Refs #5971. No product change.Background
The first A/A dispatch (run https://github.com/coder/xum/actions/runs/38013815349, base = head =
d0a00215b0, 20 pairs) succeeded, but its artifact starts with 46 lines that are not JSON: 44 runner progress lines and 2Downloading Electron binary...lines, followed by the JSON document. Ubuntu 22.04'sxvfb-runruns its command with"$@" 2>&1(line 184 ofdebian/local/xvfb-runonubuntu/jammy-updates), so the runner's stderr went into the redirected stdout. Current Debian removed the2>&1, which is why this was easy to miss.Implementation
xvfb-run -a sh -c 'node ... --json > cold-start.json': the inner shell redirects only the runner's own stdout, so stderr (progress lines) now goes to the job log. The variables still reach the step only throughenv:and are validated by the existing regex step. A scoped# shellcheck disable=SC2016marks the single quotes as intended.Validation
xvfb-runthat does"$@" 2>&1, with a stubnode. The old form gives a file that does not parse. The new form gives a file thatjq -e .parses whole, and the stub's stderr still shows on the console.make lint-actions(actionlint and zizmor) andmake static-checkpass.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high