Skip to content

🤖 ci: keep stderr out of the cold-start JSON artifact #6000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasK33 merged 1 commit into from
Oct 10, 2026
Merged

🤖 ci: keep stderr out of the cold-start JSON artifact #6000

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/desktop-cold-start.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ jobs:
cd "$RUNNER_TEMP/base" && bun install --frozen-lockfile && make build
- name: Run cold-start A/B
env: { ELECTRON_DISABLE_SANDBOX: 1 }
run: xvfb-run -a node --import tsx scripts/perf/desktopColdStart.ts --base "$RUNNER_TEMP/base" --head "$GITHUB_WORKSPACE" --pairs "$PAIRS" --json > cold-start.json
# Redirect inside sh -c: Ubuntu 22.04's xvfb-run runs the command with 2>&1, which mixed progress lines into the JSON.
run: |
# shellcheck disable=SC2016 # the inner sh -c expands these
xvfb-run -a sh -c 'node --import tsx scripts/perf/desktopColdStart.ts --base "$RUNNER_TEMP/base" --head "$GITHUB_WORKSPACE" --pairs "$PAIRS" --json > cold-start.json'
- uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
if: always()
with:
Expand Down
Loading