Avoid using strlen to get return size#326
Merged
mborland merged 1 commit intocppalliance:developfrom Feb 16, 2026
Merged
Conversation
+ leave output buffer unset
pps83
commented
Feb 14, 2026
| char buffer[64]; | ||
| const auto last {detail::mini_to_chars(buffer, value, 10, false)}; | ||
| return std::string{last}; | ||
| return std::string{last, buffer + sizeof(buffer)}; |
Contributor
Author
There was a problem hiding this comment.
perhaps, a comment explaining that mini_to_chars outputs in from the end of the buffer?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #326 +/- ##
===========================================
- Coverage 99.03% 99.03% -0.01%
===========================================
Files 64 64
Lines 5403 5402 -1
Branches 1686 1686
===========================================
- Hits 5351 5350 -1
Misses 21 21
Partials 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.