Skip to content

Avoid using strlen to get return size #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mborland merged 1 commit into from
Feb 16, 2026
Merged

Avoid using strlen to get return size #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/boost/int128/string.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ namespace int128 {
template <typename T>
auto to_string(const T& value) -> std::enable_if_t<(std::is_same<T, int128_t>::value || std::is_same<T, uint128_t>::value), std::string>
{
char buffer[64U] {};
char buffer[64];
const auto last {detail::mini_to_chars(buffer, value, 10, false)};
return std::string{last};
return std::string{last, buffer + sizeof(buffer)};
Copy link
Contributor Author

@pps83 pps83 Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps, a comment explaining that mini_to_chars outputs in from the end of the buffer?

}

} // namespace int128
Expand Down
Loading