refactor: extract stores and conformance tests into zarr-storage - #325
Draft
d-v-b wants to merge 2 commits into
Draft
refactor: extract stores and conformance tests into zarr-storage#325d-v-b wants to merge 2 commits into
d-v-b wants to merge 2 commits into
Conversation
Assisted-by: Codex:GPT-6
Draft
7 tasks
Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Extract the existing storage layer into
zarr-storage, with its current APIs inzarr_storage.legacy. The package includes the Store ABC and byte request types; MemoryStore, ManagedMemoryStore, GpuMemoryStore, LocalStore, ZipStore, FsspecStore, and ObjectStore; WrapperStore, LoggingStore, and LatencyStore; StorePath and store utilities; and experimental CacheStore.Context for this extraction:
zarr-storageandzarr-codecsubpackages that first reproduce the existing APIs, followed by new interfaces and a bridged migration. It also connects this work to modular array backends and zarrista.These are design and migration references; this draft is an initial extraction and does not complete the proposed API redesign or remove the remaining dependency on
zarr.Include the complete store test suite and cache-store tests, redirected to the extracted implementations. Distribute StoreTests, state machines, strategies, buffer test utilities, and assertion helpers under
zarr_storage.testing, with an optionaltestingextra. LatencyStore is separated from the pytest-dependent module so it can be used without pytest.This remains an initial extraction: buffers, configuration, concurrency, and some metadata/sync helpers still come from
zarr. The package must not become a Zarr dependency until this reverse dependency is removed. Zarr runtime imports remain unchanged, and the extracted classes have distinct identities. Array/group integration tests use a documented, test-only re-export fixture to exercise real Zarr arrays with the extracted stores; normal imports do not alter Zarr's bindings. No new storage contract or deprecation is introduced.Validation:
CI covers source and built-wheel tests on Python 3.12/3.14, with a Python 3.12 optional-backend job and an explicit stateful test step. GPU tests skip without appropriate hardware, and existing unsupported-backend-operation skips are preserved.