Skip to content

fix: raise exhausted cloud download errors - #638

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-613-cloud-download-errors
Open

fix: raise exhausted cloud download errors#638
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-613-cloud-download-errors

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary

  • raise RequestInfoException after all cloud download attempts fail
  • include the URL and final HTTP or transport details in the failure
  • bound response-body excerpts and close every received response
  • cover successful streaming, repeated HTTP failures, and transport failures

Closes #613

Tests

  • python -m coverage run -p --source=./dpdispatcher -m unittest -v (166 passed, 42 skipped)
  • ruff check .
  • ruff format --check .
  • dpdisp --help

Validation note: local pyright reproduces the same existing optional-dependency diagnostics in this module as upstream master; this patch adds no new diagnostic.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Report the final HTTP or transport failure instead of returning without a downloaded file.

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 57 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 37735ee8-05cd-4998-8022-bcd2431c5a36

📥 Commits

Reviewing files that changed from the base of the PR and between 34ddb4b and 69ba2f8.

📒 Files selected for processing (2)
  • dpdispatcher/utils/dpcloudserver/client.py
  • tests/test_dpcloudserver_client.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.28%. Comparing base (f547911) to head (69ba2f8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #638       +/-   ##
===========================================
+ Coverage   48.38%   59.28%   +10.89%     
===========================================
  Files          40       40               
  Lines        3960     3964        +4     
===========================================
+ Hits         1916     2350      +434     
+ Misses       2044     1614      -430     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Raise cloud download failures before unzip

1 participant