Skip to content

feat(submission): expose failed result download policy - #687

Open
SchrodingersCattt wants to merge 2 commits into
deepmodeling:masterfrom
SchrodingersCattt:feat/failed-result-policy
Open

SchrodingersCattt wants to merge 2 commits into
deepmodeling:masterfrom
SchrodingersCattt:feat/failed-result-policy

Conversation

@SchrodingersCattt

Copy link
Copy Markdown
Contributor

Summary

Expose an opt-in submission policy for workflows that need to inspect partial outputs from failed jobs without raising before the caller can apply its own scientific failure budget.

Changes

  • Add raise_on_failure=True to preserve the existing default.
  • Add include_failed_results=False to download declared files from failed tasks when they exist.
  • Preserve the existing no-argument download call path for compatibility.
  • Add focused regression coverage.

Validation

  • python -m unittest tests.test_clean_strategy tests.test_continue_after_failed_job -q
  • 34 tests passed.

This API is used by the opt-in DP-GEN exploration recovery implementation.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 919356d2-e301-4c8c-b85e-f2bf5a1c2b51

📥 Commits

Reviewing files that changed from the base of the PR and between 3b42422 and 4d6a745.

📒 Files selected for processing (2)
  • dpdispatcher/submission.py
  • tests/test_clean_strategy.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.93%. Comparing base (3b42422) to head (4d6a745).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   75.91%   75.93%   +0.01%     
==========================================
  Files          42       42              
  Lines        5427     5431       +4     
==========================================
+ Hits         4120     4124       +4     
  Misses       1307     1307              
Flag Coverage Δ
optional-dependencies 75.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant