Repository navigation
Harden Debian NVIDIA installer - #7
Conversation
- support deb822 APT sources and architecture header metapackages - avoid unsafe package-manager, DKMS, and Xorg cleanup - refresh Secure Boot and official NVIDIA download handling - document supported systems and add shell checks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54d7e2c467
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| LATEST_LINE="$(curl -fsSL https://download.nvidia.com/XFree86/Linux-x86_64/latest.txt)" || die "Could not fetch NVIDIA driver metadata." | ||
| read -r LATEST RUN_PATH _ <<<"${LATEST_LINE}" | ||
| [[ "${LATEST}" =~ ^[0-9]+(\.[0-9]+)+$ ]] || die "NVIDIA returned an invalid driver version: ${LATEST:-empty}" | ||
| [[ "${RUN_PATH}" == "${LATEST}/NVIDIA-Linux-x86_64-${LATEST}.run" ]] || die "NVIDIA returned an unexpected download path." |
There was a problem hiding this comment.
When option 5 receives NVIDIA's standard <version> <filename> response, such as 580.126.09 NVIDIA-Linux-x86_64-580.126.09.run, this comparison expects the second field to include a version directory and therefore always aborts. Because remove_nvidia has already purged the existing Debian driver, the user is left without a driver; validate the filename and construct the download URL as ${LATEST}/${RUN_PATH} instead.
Useful? React with 👍 / 👎.
1 participant
Summary
.listfiles and deb822.sourceslatest.txtmetadataThis addresses the Debian 12 CUDA report in #1 and incorporates the valid intent of #6 without dropping exact running-kernel headers.
Validation
bash -n install-nvidia-cuda.shgit diff --check