Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dimos/visualization/rerun/bridge.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@

from dimos.core.core import rpc
from dimos.core.module import Module, ModuleConfig
from dimos.msgs.sensor_msgs.PointCloud2 import register_colormap_annotation
from dimos.protocol.pubsub.impl.lcmpubsub import LCM
from dimos.protocol.pubsub.patterns import Glob, pattern_matches
from dimos.protocol.pubsub.spec import SubscribeAllCapable
Expand Down Expand Up @@ -307,6 +308,8 @@ def start(self) -> None:
# Initialize and spawn Rerun viewer
rerun_init("dimos")

register_colormap_annotation("turbo")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Duplicate register_colormap_annotation call

rerun_init() already calls register_colormap_annotation("turbo") internally (see dimos/visualization/rerun/init.py line 27). Adding this explicit call here means rr.log("/", rr.AnnotationContext([...256 entries...]), static=True) is logged twice per bridge startup — both the allocation and the log operation are redundant. The second invocation should be removed.


if self.config.viewer_mode == "native":
try:
import rerun_bindings
Expand Down
18 changes: 18 additions & 0 deletions pr_responses.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
- pr: 1922
comment_id: 3151786732
author: leshy
file: dimos/visualization/rerun/bridge.py
line: 305
problem: >
"I need to init rerun without a bridge for memory stuff, which 'grpc work'
do you need to do? what's the issue?"
solution: >
The issue is that register_colormap_annotation (called before serve_grpc)
needs a recording stream, but the recording stream can only be created
after the gRPC server starts. The PR refactors init order so serve_grpc
runs first, then register_colormap_annotation runs against the live
recording. This is specific to the bridge use-case where the viewer
connection is gRPC-based. For non-bridge rerun usage (like memory),
rr.init() alone is sufficient since there's no gRPC dependency.
Requires PR author input on whether to respond directly to leshy.
commit: null
Comment on lines +1 to +18
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Internal tracking file committed to repo

pr_responses.yaml appears to be an internal development or AI-assisted review-tracking artifact. It contains reviewer conversation notes and internal decision points (e.g., "Requires PR author input on whether to respond directly to leshy"), and does not belong in the source tree. This file should be removed from the PR and added to .gitignore.

Loading