-
Notifications
You must be signed in to change notification settings - Fork 555
fix: rerun viewer not auto-opening #1922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
89f9431
c4984e7
dcefeb2
246743a
49851e5
da91707
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| - pr: 1922 | ||
| comment_id: 3151786732 | ||
| author: leshy | ||
| file: dimos/visualization/rerun/bridge.py | ||
| line: 305 | ||
| problem: > | ||
| "I need to init rerun without a bridge for memory stuff, which 'grpc work' | ||
| do you need to do? what's the issue?" | ||
| solution: > | ||
| The issue is that register_colormap_annotation (called before serve_grpc) | ||
| needs a recording stream, but the recording stream can only be created | ||
| after the gRPC server starts. The PR refactors init order so serve_grpc | ||
| runs first, then register_colormap_annotation runs against the live | ||
| recording. This is specific to the bridge use-case where the viewer | ||
| connection is gRPC-based. For non-bridge rerun usage (like memory), | ||
| rr.init() alone is sufficient since there's no gRPC dependency. | ||
| Requires PR author input on whether to respond directly to leshy. | ||
| commit: null | ||
|
Comment on lines
+1
to
+18
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
register_colormap_annotationcallrerun_init()already callsregister_colormap_annotation("turbo")internally (seedimos/visualization/rerun/init.pyline 27). Adding this explicit call here meansrr.log("/", rr.AnnotationContext([...256 entries...]), static=True)is logged twice per bridge startup — both the allocation and the log operation are redundant. The second invocation should be removed.