Parse analysis level with invariant culture #81438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return analyzerConfigOptions.TryGetValue(AnalysisLevelKey, out var value) | ||
| && double.TryParse(value, out var version) | ||
| && double.TryParse(value, NumberStyles.Float | NumberStyles.AllowThousands, CultureInfo.InvariantCulture, out var version) |
Member
There was a problem hiding this comment.
I feel like I have worked in codebases in the past where all of the 'format' and 'parse' methods involving strings would have an analyzer to mandate the use of an IFormatProvider; is this something where we should check to see if the rule is enabled?
Member
Author
There was a problem hiding this comment.
I found CA1305 but when I've tried enabling it, it didn't catch double.TryParse anyway (perhaps because the overload with IFormatProvider has also the additional NumberStyles parameter).
CyrusNajmabadi
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81417.