Skip to content

Parse analysis level with invariant culture #81438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjonescz merged 1 commit into from
Nov 26, 2025
Merged

Parse analysis level with invariant culture #81438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .../SharedUtilitiesAndExtensions/Compiler/Core/Extensions/AnalyzerConfigOptionsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.

using System.Globalization;
using Microsoft.CodeAnalysis.CodeStyle;
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Diagnostics.Analyzers.NamingStyles;
Expand Down Expand Up @@ -67,7 +68,7 @@ public static bool IsAnalysisLevelGreaterThanOrEquals(this AnalyzerConfigOptions
const string AnalysisLevelKey = "build_property.EffectiveAnalysisLevelStyle";

return analyzerConfigOptions.TryGetValue(AnalysisLevelKey, out var value)
&& double.TryParse(value, out var version)
&& double.TryParse(value, NumberStyles.Float | NumberStyles.AllowThousands, CultureInfo.InvariantCulture, out var version)
Copy link
Member

@phil-allen-msft phil-allen-msft Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I have worked in codebases in the past where all of the 'format' and 'parse' methods involving strings would have an analyzer to mandate the use of an IFormatProvider; is this something where we should check to see if the rule is enabled?

Copy link
Member Author

@jjonescz jjonescz Nov 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found CA1305 but when I've tried enabling it, it didn't catch double.TryParse anyway (perhaps because the overload with IFormatProvider has also the additional NumberStyles parameter).

&& version >= minAnalysisLevel;
}
}
Loading