[Android] "What’s New" promo message: Implement pixels

[anikiki]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1200581511062568/task/1211783737656685?focus=true

Description

Added pixel tracking for CardsList remote messages. This PR introduces a new CardsListRemoteMessagePixelHelper class that handles firing pixels for card-specific events (shown, clicked, dismissed) with appropriate parameters. The implementation tracks when cards are shown to users, when users interact with cards, and how messages are dismissed.

Steps to test this PR

CardsList Remote Message Tracking

• Verify that when a CardsList message is shown, the m_remote_message_card_shown pixel fires for each card
• Verify that when a card item is clicked, the m_remote_message_card_clicked pixel fires with the correct card ID
• Verify that when a message is dismissed via close button or via the back navigation, the m_remote_message_dismissed pixel fires with the appropriate dismiss type parameter
• Verify the other existing RMF pixels are fired (message shown, primary action clicked)

NO UI changes

---

Note

Implements card-specific pixels and dismissal tracking for CardsList remote messages, adds back navigation dismiss handling, and defines new pixel specs with comprehensive tests.

• Remote Messaging (CardsList)
  • Pixel helper: Add CardsListRemoteMessagePixelHelper (fireCardItemShownPixel, fireCardItemClickedPixel, dismissCardsListMessage) with parameters message, card, and optional dismissType.
  • ViewModel updates: In CardsListRemoteMessageViewModel, track last message, fire onMessageShown (including per-card m_remote_message_card_shown), log m_remote_message_card_clicked on item taps, and dismiss with m_remote_message_dismissed including dismissType=close_button.
  • View update: Call viewModel.onMessageShown() on render in CardsListRemoteMessageView.
  • Activity/ViewModel (ModalSurface): Wire back navigation to emit m_remote_message_dismissed with dismissType=back_button_or_gesture via ModalSurfaceViewModel.onBackPressed().
• Pixels
  • Define m_remote_message_card_shown and m_remote_message_card_clicked in PixelDefinitions/pixels/remote_messaging_framework.json5.
• Tests
  • Add unit tests for helper (RealCardsListRemoteMessagePixelHelperTest), CardsListRemoteMessageViewModel, and ModalSurfaceViewModel covering show, click, and dismiss (including dismissType).

^{Written by Cursor Bugbot for commit b411140. This will update automatically on new commits. Configure here.}

[anikiki]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• [Android] "What’s New" promo message: Implement pixels #7292 : 2 dependent PRs (#7324 , #7343 ) 👈 (View in Graphite)
• [Android] "What’s New" promo message: Add the new UI elements #7256
• [Android] "What’s New" promo message: Add new action to open Password in System Settings #7246
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Bug: Missing duplicate prevention for "shown" pixels

The onMessageShown() call in render() lacks the duplicate prevention check present in the existing RemoteMessageView. The ViewModel computes newMessage (line 70) but doesn't include it in ViewState or use it to guard pixel firing. In contrast, the existing RemoteMessageView uses shouldRender = newMessage || binding.root.visibility == View.GONE before calling onMessageShown(). Without this check, the card "shown" pixels will fire every time render() is called with the same message, such as after configuration changes, leading to duplicate anonymous measurement data.

---

_{Please tell me if this was useful or not with a 👍 or 👎.}

Additional Locations (1)

• remote-messaging/remote-messaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/ui/CardsListRemoteMessageViewModel.kt#L69-L77

 

[cursor]

Bug: Dismiss command sent before pixel and repository operations

In onCloseButtonClicked(), the Command.DismissMessage is sent before cardsListPixelHelper.dismissCardsListMessage() is called. This could cause a race condition where the activity finishes before the pixel fires and the message is dismissed in the repository. Compare with onBackPressed() in ModalSurfaceViewModel which correctly calls dismissCardsListMessage() first and sends the dismiss command afterward. The inconsistent ordering in onCloseButtonClicked() could result in missed anonymous measurements and messages not being properly marked as dismissed.

---

_{Please tell me if this was useful or not with a 👍 or 👎.}