[Android] "What’s New" promo message: Prompt dispatcher - modal coordinator #7343

anikiki · 2025-12-11T22:56:44Z

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1212329205023394?focus=true

Description

Implemented a new Modal Coordinator system that manages when and how modals are shown in the app. This system:

Creates a priority-based evaluation mechanism where evaluators run in order (lower number = higher priority)
Implements a 24-hour cooldown period to prevent multiple modals from appearing too frequently
Migrates existing modal-like components (RemoteMessageModalSurfaceEvaluator and AdditionalDefaultBrowserPromptsImpl) to use the new system
Ensures only one modal can be shown at a time, improving user experience

Steps to test this PR

See detailed testing scenarios and help in the Testing section in the description of https://app.asana.com/1/137249556945/project/1200581511062568/task/1212329205023394?focus=true

Modal Coordinator System

Verify that modals appear in priority order (RemoteMessageModal has priority 1, DefaultBrowserPrompts has priority 2)
Confirm that after a modal is shown, no other modals appear for 24 hours
Check that migrated components (remote messages, default browser prompts) still function correctly

Default Browser Prompts

Verify the default browser prompts still appear at appropriate times
Confirm the prompts respect the modal coordination system's rules

Remote Message Modals

Verify remote message modals still appear when expected
Confirm they respect the priority system and cooldown period

Note

Adds a prioritized modal coordination system with 24‑hour cooldown and migrates Remote Message modal and Default Browser prompts to it.

Modal Coordination (new)
- Add modal-coordinator-api with ModalEvaluator and ModalEvaluatorCompletionStore.
- Add modal-coordinator-impl with ModalEvaluatorCoordinator (priority-based, single-run per resume, 24h cooldown) and DataStore-backed completion store.
Integrations
- Wire modules in app/build.gradle and depend on API from remote-messaging-impl.
Migrations
- RemoteMessageModalSurfaceEvaluator -> implements ModalEvaluator (priority 1), enforces 4h background threshold via completion store, launches modal and clears timestamp.
- AdditionalDefaultBrowserPromptsImpl -> implements ModalEvaluator (priority 2), refactors evaluate to return EvaluationResult; removes lifecycle observer hooks; minor IO dispatching tweak.
Tests
- Add unit tests for coordinator behavior and completion store.
- Update/add tests for remote messaging modal evaluator and default browser prompts evaluator.

^{Written by Cursor Bugbot for commit 661ffa2. This will update automatically on new commits. Configure here.}

anikiki · 2025-12-11T22:57:06Z

[Android] "What’s New" promo message: Make the ModalSurfaceActivity handle any remote message we support #7368
[Android] "What’s New" promo message: Matching rules and excusion rules at card item level #7360
[Android] "What’s New" promo message: Prompt dispatcher - modal coordinator #7343 👈 (View in Graphite)
[Android] "What’s New" promo message: Implement pixels #7292 : 1 other dependent PR (#7324 )
[Android] "What’s New" promo message: Add the new UI elements #7256
[Android] "What’s New" promo message: Add new action to open Password in System Settings #7246
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

anikiki · 2025-12-15T15:32:45Z

...va/com/duckduckgo/app/browser/defaultbrowsing/prompts/AdditionalDefaultBrowserPromptsImpl.kt

-    init {
-        appCoroutineScope.launch {
-            userStageStore.userAppStageFlow().collect {
-                evaluate()


Removed this as it's not really needed and created more issues. I wanted to remove it when I worked on the initial project, but forgot.

anikiki · 2025-12-15T15:34:06Z

...va/com/duckduckgo/app/browser/defaultbrowsing/prompts/AdditionalDefaultBrowserPromptsImpl.kt

-    override fun onResume(owner: LifecycleOwner) {
-        super.onResume(owner)
-        appCoroutineScope.launch {
-            evaluate()


This is now called as part of ModalEvaluatorCoordinator's onResume.

anikiki · 2025-12-15T15:34:19Z

...va/com/duckduckgo/app/browser/defaultbrowsing/prompts/AdditionalDefaultBrowserPromptsImpl.kt

-        appCoroutineScope.launch {
+        appCoroutineScope.launch(dispatchers.io()) {
            featureSettings = defaultBrowserPromptsFeatureToggles.parseFeatureSettings()
-            evaluate()


Again, not needed, removed.

anikiki · 2025-12-15T15:35:02Z

...va/com/duckduckgo/app/browser/defaultbrowsing/prompts/AdditionalDefaultBrowserPromptsImpl.kt

            defaultBrowserPromptsDataStore.storeShowSetAsDefaultMessageState(action.showMessage)
+
+            return@withLock if (action.showMessageDialog) {
+                ModalEvaluator.EvaluationResult.CompletedWithAction


This is the only place where a modal is shown, hence the only place that returns CompletedWithAction.

anikiki · 2025-12-15T15:36:19Z

.../src/main/java/com/duckduckgo/remote/messaging/impl/ui/RemoteMessageModalSurfaceEvaluator.kt

-    override fun onResume(owner: LifecycleOwner) {
-        super.onResume(owner)
-        appCoroutineScope.launch {
-            evaluate()


Moved to ModalEvaluatorCoordinator onResume

anikiki · 2025-12-15T15:36:55Z

.../src/main/java/com/duckduckgo/remote/messaging/impl/ui/RemoteMessageModalSurfaceEvaluator.kt


-                intent.flags = Intent.FLAG_ACTIVITY_NEW_TASK or Intent.FLAG_ACTIVITY_SINGLE_TOP
-                applicationContext.startActivity(intent)
+                return@withContext ModalEvaluator.EvaluationResult.CompletedWithAction


As in the other evaluator, this is the place a modal is shown, hence returning CompletedWithAction

.../src/main/java/com/duckduckgo/remote/messaging/impl/ui/RemoteMessageModalSurfaceEvaluator.kt

...rc/main/java/com/duckduckgo/modalcoordinator/impl/store/ModalEvaluatorCompletionStoreImpl.kt

…nd 24-hour blocking.

…ckground timestamp management. Removed dependency to SettingsDataStore.

…thods and update background timestamp retrieval logic.

…OwnerMock usage with evaluate method calls.

…nator and RemoteMessageModalSurfaceEvaluatorImpl.

…check logic.

cmonfortep

Code wise, looks good.

I have some concerns with behavior we introduce, and implicit behavior of the modal. Left some comments about that.

My main concern on the behavior: After a modal is shown, if we restart the app, the modal doesn't show, but it will show again after 24h.

My expectation will be: After the modal is shown, even if we restart the app, it shows again if the modal needs to show (that logic belongs to the modal). Coordinator only makes sure that after the modal is gone, we do a 24h cooldown, if that's the requirement.

cmonfortep · 2025-12-18T14:09:12Z

...nator-api/src/main/java/com/duckduckgo/modalcoordinator/api/ModalEvaluatorCompletionStore.kt

+
+package com.duckduckgo.modalcoordinator.api
+
+interface ModalEvaluatorCompletionStore {


I think we missed the api proposal for this api. From a quick look, not all methods are used outside this api. Exposing the Store in the api also feels not ideal.

If the purpose of modal-coordinator is to avoid multiple modals showing at the same time, the logic around cooldown period or background checks might not need to be exposed. If we need that, we should probably include it when implementing the plugin.

cmonfortep · 2025-12-18T14:39:04Z

...dinator-impl/src/main/java/com/duckduckgo/modalcoordinator/impl/ModalEvaluatorCoordinator.kt

+            logcat { "ModalEvaluatorCoordinator: Evaluating '${evaluator.evaluatorId}' (priority ${evaluator.priority})" }
+
+            // Start evaluation
+            when (evaluator.evaluate()) {


Here relies the issue I mentioned on MM about modals blocking themselves if the app restarts, and appearing again after 24h.

Few things I see:

when evaluate returns CompletedWithAction and we record completion.

completion is confusing, or at least I don't think it matches the definition of completion on every modal. Right now we know (or expect) they have been shown.

I think the modal itself should track their own state (e.g: RMF will own his own state on the database like scheduled, dismissed, done)

Here I would just track timestamp and id

One proposal here (not sure if it will work) will be to update the logic so we store the time the modal is shown (like you do now) and the id. If within the 24h threshold, we only call evaluate for the plugin with that Id. That way we allow only the modal that was last shown to appear within that 24h window. Others will need to wait for the cool down to finish.

cmonfortep · 2025-12-18T14:48:18Z

.../src/main/java/com/duckduckgo/remote/messaging/impl/ui/RemoteMessageModalSurfaceEvaluator.kt

+                return@withContext ModalEvaluator.EvaluationResult.Skipped
+            }
+
+            if (!hasMetBackgroundTimeThreshold()) {


I don't fully understand why this logic. So the app needs to be in the background for more than 4h in order to show. I would do that if the event is onResume, but if it's an app fresh start, why do we need that? is that a requirement?

cmonfortep · 2025-12-18T14:49:10Z

...or/modal-coordinator-api/src/main/java/com/duckduckgo/modalcoordinator/api/ModalEvaluator.kt

+    sealed class EvaluationResult {
+
+        /** Evaluation completed and modal was shown/triggered */
+        object CompletedWithAction : EvaluationResult()


I think if this is to represent shown we should rename to something that makes that clear.

This was referenced Dec 11, 2025

[Android] "What’s New" promo message: Add new action to open Password in System Settings #7246

Merged

[Android] "What’s New" promo message: Add the new UI elements #7256

Merged

[Android] "What’s New" promo message: Implement pixels #7292

Merged

anikiki mentioned this pull request Dec 11, 2025

Implement background time threshold check for modal message display. #7324

Closed

3 tasks

anikiki force-pushed the feaure/ana/android_whats_new_promo_message_update_the_remotemessagemodalsurfaceevaluatorimpl_with_all_conditions branch from 92ec7e1 to a7d6647 Compare December 11, 2025 23:24

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from f80d95b to 4dd0807 Compare December 11, 2025 23:24

anikiki force-pushed the feaure/ana/android_whats_new_promo_message_update_the_remotemessagemodalsurfaceevaluatorimpl_with_all_conditions branch from a7d6647 to 05e9c3e Compare December 12, 2025 00:25

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from 4dd0807 to afd2782 Compare December 12, 2025 00:25

anikiki force-pushed the feaure/ana/android_whats_new_promo_message_update_the_remotemessagemodalsurfaceevaluatorimpl_with_all_conditions branch from 05e9c3e to 1bfabe0 Compare December 12, 2025 11:05

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from afd2782 to 1874dd5 Compare December 12, 2025 11:05

anikiki force-pushed the feaure/ana/android_whats_new_promo_message_update_the_remotemessagemodalsurfaceevaluatorimpl_with_all_conditions branch from 1bfabe0 to 068f409 Compare December 12, 2025 13:25

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from 1874dd5 to 998e90e Compare December 12, 2025 13:25

anikiki changed the base branch from feaure/ana/android_whats_new_promo_message_update_the_remotemessagemodalsurfaceevaluatorimpl_with_all_conditions to feature/ana/android_whats_new_promo_message_implement_pixels December 12, 2025 19:04

anikiki changed the title ~~Add modal coordinator implementation with priority-based evaluation and 24-hour blocking.~~ [Android] "What’s New" promo message: Prompt dispatcher - modal coordinator Dec 13, 2025

anikiki force-pushed the feature/ana/android_whats_new_promo_message_implement_pixels branch from 366bbc1 to b411140 Compare December 13, 2025 21:09

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from 40609a5 to 64ebebb Compare December 13, 2025 21:09

anikiki commented Dec 15, 2025

View reviewed changes

anikiki force-pushed the feature/ana/android_whats_new_promo_message_implement_pixels branch from b411140 to 9c0c2a1 Compare December 15, 2025 16:07

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from 08e3793 to 091a355 Compare December 15, 2025 16:07

anikiki marked this pull request as ready for review December 15, 2025 17:28

anikiki requested a review from cmonfortep December 15, 2025 17:28

anikiki assigned cmonfortep Dec 15, 2025

cursor bot reviewed Dec 15, 2025

View reviewed changes

.../src/main/java/com/duckduckgo/remote/messaging/impl/ui/RemoteMessageModalSurfaceEvaluator.kt Show resolved Hide resolved

cursor bot reviewed Dec 15, 2025

View reviewed changes

.../src/main/java/com/duckduckgo/remote/messaging/impl/ui/RemoteMessageModalSurfaceEvaluator.kt Show resolved Hide resolved

anikiki mentioned this pull request Dec 15, 2025

[Android] "What’s New" promo message: Matching rules and excusion rules at card item level #7360

Open

4 tasks

anikiki force-pushed the feature/ana/android_whats_new_promo_message_implement_pixels branch 2 times, most recently from 12c6b27 to 507fc69 Compare December 16, 2025 11:08

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from 2549ea7 to f4be73c Compare December 16, 2025 11:08

cursor bot reviewed Dec 16, 2025

View reviewed changes

...rc/main/java/com/duckduckgo/modalcoordinator/impl/store/ModalEvaluatorCompletionStoreImpl.kt Show resolved Hide resolved

anikiki changed the base branch from feature/ana/android_whats_new_promo_message_implement_pixels to graphite-base/7343 December 16, 2025 11:34

anikiki force-pushed the graphite-base/7343 branch from 507fc69 to 970a291 Compare December 16, 2025 11:35

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from f4be73c to 1045448 Compare December 16, 2025 11:35

graphite-app bot changed the base branch from graphite-base/7343 to develop December 16, 2025 11:35

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from 1045448 to 51a045a Compare December 16, 2025 11:35

anikiki added 8 commits December 16, 2025 17:24

Implement background time threshold check for modal message display.

bdd53a2

Add modal coordinator implementation with priority-based evaluation a…

910edcd

…nd 24-hour blocking.

Add ModalEvaluatorCompletionStore interface and implementation for ba…

deb2966

…ckground timestamp management. Removed dependency to SettingsDataStore.

Refactor ModalEvaluatorCompletionStore to add timestamp management me…

84ff505

…thods and update background timestamp retrieval logic.

Refactor AdditionalDefaultBrowserPromptsImplTest to replace lifecycle…

979c670

…OwnerMock usage with evaluate method calls.

Add tests for ModalEvaluatorCompletionStoreImpl, ModalEvaluatorCoordi…

3b726f1

…nator and RemoteMessageModalSurfaceEvaluatorImpl.

Fixed lint.

27d75d6

Clear background timestamp when showing modal and simplify threshold …

661ffa2

…check logic.

anikiki force-pushed the feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator branch from 51a045a to 661ffa2 Compare December 16, 2025 17:24

anikiki mentioned this pull request Dec 16, 2025

[Android] "What’s New" promo message: Make the ModalSurfaceActivity handle any remote message we support #7368

Closed

5 tasks

cmonfortep reviewed Dec 18, 2025

View reviewed changes


		package com.duckduckgo.modalcoordinator.api

		interface ModalEvaluatorCompletionStore {

[Android] "What’s New" promo message: Prompt dispatcher - modal coordinator #7343

Are you sure you want to change the base?

[Android] "What’s New" promo message: Prompt dispatcher - modal coordinator #7343

Conversation

anikiki commented Dec 11, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Steps to test this PR

Uh oh!

anikiki commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmonfortep left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

anikiki commented Dec 11, 2025 •

edited by cursor bot

Loading

anikiki commented Dec 11, 2025 •

edited

Loading