[Android] "What’s New" promo message: Matching rules and excusion rules at card item level #7360
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
anikiki
changed the title
anikiki
force-pushed
the
feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator
branch
from
2549ea7 to
f4be73c
Compare
anikiki
force-pushed
the
feature/ana/android/whats_new_promo_message_matching_rules_and_excusion_rules_at_card_item_level
branch
from
384bda0 to
12cfe3c
Compare
anikiki
force-pushed
the
feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator
branch
2 times, most recently
from
1045448 to
51a045a
Compare
anikiki
force-pushed
the
feature/ana/android/whats_new_promo_message_matching_rules_and_excusion_rules_at_card_item_level
branch
from
12cfe3c to
8528578
Compare
anikiki
force-pushed
the
feature/ana/android_whats_new_promo_message_prompt_dispatcher_modal_coordinator
branch
from
51a045a to
661ffa2
Compare
anikiki
force-pushed
the
feature/ana/android/whats_new_promo_message_matching_rules_and_excusion_rules_at_card_item_level
branch
from
8528578 to
839f2eb
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| val itemExclusion = if (cardItem.exclusionRules.isEmpty()) { | ||
| EvaluationResult.Fail | ||
| } else { | ||
| cardItem.exclusionRules.evaluateExclusionRules(message.id, rules) |
There was a problem hiding this comment.
Bug: Card item percentile rules use parent message ID
When evaluating card item rules in filterCardsListMessage, message.id is passed to evaluateMatchingRules and evaluateExclusionRules instead of cardItem.id. These functions use this ID for percentile cohort lookups via remoteMessagingCohortStore.getPercentile(messageId). This means all card items within a message share the same percentile cohort value, so if rules with targetPercentile are used on card items, they cannot have independent percentage-based rollouts - they'll all pass or fail together based on the message's percentile. If independent per-card percentile targeting is intended, the card item's own id would need to be passed instead.
Please tell me if this was useful or not with a 👍 or 👎.
There was a problem hiding this comment.
this is probably correct. If there's a rule used by an item, we should pass the cardItem.id. We use that id to store the percentile and keep the logic deterministic.
The message will have its own percentile to decide % for the message. The item percentile should belong to them.
| } | ||
|
|
||
| @Test | ||
| fun whenCardsListMessageWithAllCardItemsFailingRulesThenReturnsNull() = runBlocking { |
There was a problem hiding this comment.
I think this makes sense, but checking with iOS if that was captured on the requirements.
| } | ||
|
|
||
| @Test | ||
| fun whenNonCardsListMessageThenReturnsMessageUnmodified() = runBlocking { |
There was a problem hiding this comment.
Not sure I understand the purpose of this test.
| val itemExclusion = if (cardItem.exclusionRules.isEmpty()) { | ||
| EvaluationResult.Fail | ||
| } else { | ||
| cardItem.exclusionRules.evaluateExclusionRules(message.id, rules) |
There was a problem hiding this comment.
this is probably correct. If there's a rule used by an item, we should pass the cardItem.id. We use that id to store the percentile and keep the logic deterministic.
The message will have its own percentile to decide % for the message. The item percentile should belong to them.
2 participants
Task/Issue URL: https://app.asana.com/1/137249556945/task/1212464602611971?focus=true
Description
Added support for per-card item matching and exclusion rules in the remote messaging system. This enhancement allows for more granular control over which card items are displayed within a CardsList message.
Steps to test this PR
Check the instructions for testing in the description of the task -> https://app.asana.com/1/137249556945/task/1212464602611971?focus=true
CardsList filtering
NO UI changes
Note
Adds per-card matching/exclusion rules for
CardsListmessages and filters list items accordingly, with JSON mapping updates and comprehensive tests.CardItemfields:matchingRules,exclusionRulesinremote-messaging-api.RemoteMessagingConfigMatcher, processContent.CardsListby evaluating eachCardItem'smatchingRules/exclusionRules.listItems; returnnullif all items are filtered; non-CardsListmessages unchanged.JsonListItemwithmatchingRules/exclusionRulesand map them inJsonRemoteMessageMapper.CardItemfields.Written by Cursor Bugbot for commit 839f2eb. This will update automatically on new commits. Configure here.