Repository navigation
Conversation
… a String (currently holds reqwest::Error, which isn't available at the
api_bridge layer): pub struct ConnectionFailedError { pub message: String }
2. codex-rs/core/src/api_bridge.rs:109 — Route Network to ConnectionFailed: TransportError::Network(msg) =>
CodexErr::ConnectionFailed(ConnectionFailedError { message: msg }),
TransportError::Build(msg) => CodexErr::Stream(msg, None), // build errors aren't transport disconnects
3. codex-rs/core/src/codex.rs — The three string patterns in should_retry_once_on_transport_disconnect can be removed for the "error sending
request for url" case (now structural). The remaining two ("connection closed before message completed", "connection reset") cover SSE mid-stream
drops — a separate code path through codex-api SSE processing that doesn't go through transport.rs:map_error(). Those could remain as a narrower
fallback, or be addressed in a follow-up by adding classification in the SSE layer.
…lot models The GitHub Copilot /models endpoint filters results based on the Openai-Intent header. When 'conversation-edits' was sent, only GPT models were returned — Gemini and Claude models were silently excluded. Fix: strip the openai-intent header before making the /models GET request so the API returns all subscription models. Also fix the TUI model popup to show non-auto models as individual items instead of collapsing them into an 'All models' submenu. Tests added at three layers: - Unit test verifying /models request omits openai-intent header - In-process E2E test via TestCodexBuilder with mock copilot server - CLI binary E2E test spawning actual codex binary against mock server Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fix: preserve provider-backed model switching
|
Superseded by I rebuilt the consolidation branch fresh off
I intentionally did not continue with the old divergent history from Recommendation: use |
|
Superseded by #38, which now carries the consolidated branch with the rebased model-switching fixes plus the CI npm-staging fix. Please do not merge this branch separately. |
|
Superseded by #38, which now carries the consolidated |
|
Superseded by direct landing on main at 1328bae. |
2 participants
Closes #34
Summary
issue-22issue-21andissue-26issue-27andissue-28as the integration spine because they already contain the current CI/workflow fixesValidation
sh scripts/install/test-source-build-install.shcodex-tuimodel switching coverage in progress on the consolidated worktreeNotes