Repository navigation
fix: retry repeated transient stream disconnects - #42
Merged
Merged
Conversation
This was referenced Mar 26, 2026
Owner
Author
|
CI note: the currently failing Tracked separately:
The retry change in this PR is covered locally by the focused |
dzianisv
force-pushed
the
issue-41-retry-transport-disconnects
branch
from
March 28, 2026 07:31
dceeee7 to
c8a5dc3
Compare
Owner
Author
|
Rebased this branch onto the latest Local validation completed:
Current blockers are fork-wide CI issues rather than branch-local behavior:
|
dzianisv
force-pushed
the
issue-41-retry-transport-disconnects
branch
from
March 28, 2026 16:04
c8a5dc3 to
fb11787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_max_retries = 0and the stream failed due to a transient transport disconnectcodex execreplaying repeated incomplete SSE streamsCloses #41.
Testing
CARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/Users/engineer/workspace/codex/codex-rs/target cargo test -p codex-core effective_stream_retry_budget --color neverCARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/Users/engineer/workspace/codex/codex-rs/target cargo test -p codex-core --test all suite::stream_no_completed::retries_replayed_stream_request_when_stream_retries_are_disabled --color never -- --exactCARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/Users/engineer/workspace/codex/codex-rs/target cargo build -p codex-cli --bin codex --color neverCARGO_INCREMENTAL=0 CARGO_TARGET_DIR=/Users/engineer/workspace/codex/codex-rs/target cargo test -p codex-core --test all suite::cli_stream::responses_mode_stream_cli_retries_replayed_stream_request_when_stream_retries_disabled --color never -- --exact