Single-use CI approval label, and job names from _resolved - #340
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6AjwaXjYyz95oZSd3Grwi
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X6AjwaXjYyz95oZSd3Grwi
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015mHyqKGJ3Bu8RAnKdQhguB
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015mHyqKGJ3Bu8RAnKdQhguB
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015mHyqKGJ3Bu8RAnKdQhguB
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #340 +/- ##
===========================================
+ Coverage 67.55% 67.60% +0.04%
===========================================
Files 1182 1182
Lines 61862 61862
Branches 4675 4675
===========================================
+ Hits 41793 41822 +29
+ Misses 20069 20040 -29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015RsLA9yt5sthqAuLFjBHdm
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015RsLA9yt5sthqAuLFjBHdm
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015RsLA9yt5sthqAuLFjBHdm
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015RsLA9yt5sthqAuLFjBHdm
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DKeM8m3VXyKSiydpp8kPqA
iainrussell
approved these changes
Sep 14, 2026
pmaciel
pushed a commit
that referenced
this pull request
Sep 14, 2026
Single-use CI approval label, and job names from _resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything the CI rollout has open for this repo, as one pull request instead of a
two-deep stack. Supersedes #337 and #338 — same branch, same commits, no rebase;
GitHub simply refuses to retarget a PR that is part of a stack.
Two changes:
_resolved.job-name. One name, computed once byresolve-deps, instead of each workflow spelling out its own${{ matrix.platform }}, ${{ matrix['cxx-compiler'] }}— which is how the CIand cross-repo lanes drift apart.
approved-for-cilabel is single-use.require-ci-approvalnow spendsthe label the moment it is honoured, so one approval buys one run and a
contributor cannot earn approval on a harmless diff and replay it. Adds
.github/ci-approval-allowlist.ymlfor the legacy workflows that are exempt.The regenerated
trigger-downstream{,-hpc}.ymlare what actually make downstreamCI green again: the orchestrator now resolves the commit under test through a
contextjob, andlabel-gateusesgithub.tokenwith an explicitpermissions:block rather than a minted App token.Why downstream CI is red without this
ci-infrastructure@mainis ateab560cc, which changed the rendered orchestrator.This repo's
developstill carries the previous render, so the orchestrator'svalidatejob fails, every consumer job is skipped, anddownstream/runnerflipsto failure. Verified by re-running the generator's
--checkagainstdevelop(stale) and against this branch (clean).
Merged
developin; it touched no CI files, and regenerating produces no delta.🤖 Generated with Claude Code
https://claude.ai/code/session_015RsLA9yt5sthqAuLFjBHdm
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/eckit/pull-requests/PR-340
Contributor Declaration
By opening this pull request, I affirm the following: