Skip to content

Fix west installation of scaffold - #8

Merged
MilhoNerfado merged 1 commit into
mainfrom
hotfix-west
May 5, 2026
Merged

MilhoNerfado merged 1 commit into
mainfrom
hotfix-west

Conversation

@MilhoNerfado

@MilhoNerfado MilhoNerfado commented May 5, 2026 •

Copy link
Copy Markdown
Collaborator

This pull request updates the project's dependencies and configuration files to improve package management and development workflows. The most important changes are grouped below:

Dependency management improvements:

  • Added the rich library as a required dependency in pyproject.toml.
  • Introduced an optional dev dependency group in pyproject.toml with ruff and pytest for development and testing.

Build and requirements file updates:

  • Removed the editable install of the scaffold tool from requirements-west.txt, likely to avoid redundancy or conflicts.
  • Updated the zephyr/module.yml configuration to use requirements.txt instead of requirements-west.txt for pip dependencies, aligning with standard practices.

Signed-off-by: Emilio Bottoni <emilio.bottoni@edge.ufal.br>
@MilhoNerfado MilhoNerfado self-assigned this May 5, 2026
@MilhoNerfado
MilhoNerfado merged commit a00e7b2 into main May 5, 2026
6 checks passed
@MilhoNerfado
MilhoNerfado deleted the hotfix-west branch May 5, 2026 12:36

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency management by modifying pyproject.toml and requirements.txt, and redirecting the Zephyr module configuration. Feedback identifies duplicated and potentially invalid versioning for the rich library in both dependency files. Additionally, development dependencies like ruff and pytest should be removed from requirements.txt to prevent unnecessary installations for end-users.

Comment thread pyproject.toml
Comment on lines +9 to +14
"rich>=13.0",
"jinja2>=3.1",
"platformdirs>=4.0",
"pyyaml>=6.0",
"jsonschema>=4.18",
"rich>=15.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rich dependency is duplicated at lines 9 and 14. Furthermore, version 15.0 appears to be incorrect as the current stable version of rich is 13.x. This will likely cause installation to fail. Please remove the duplicate and verify the required version.

Suggested change
"rich>=13.0",
"jinja2>=3.1",
"platformdirs>=4.0",
"pyyaml>=6.0",
"jsonschema>=4.18",
"rich>=15.0",
"rich>=13.0",
"jinja2>=3.1",
"platformdirs>=4.0",
"pyyaml>=6.0",
"jsonschema>=4.18",

Comment thread requirements.txt
Comment on lines +3 to +8
rich>=13.0
jinja2>=3.1
platformdirs>=4.0
pyyaml>=6.0
jsonschema>=4.18
rich>=15.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rich dependency is duplicated here as well. It is recommended to keep only one entry with the correct version constraint.

rich>=13.0
jinja2>=3.1
platformdirs>=4.0
pyyaml>=6.0
jsonschema>=4.18

Comment thread requirements.txt
Comment on lines 10 to +11
ruff
pytest>=8.0
pytest

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Development dependencies (ruff and pytest) should not be included in the main requirements.txt file, as this file is used for the Zephyr module installation via west. These are already defined in the dev section of pyproject.toml. Including them here forces end-users to install unnecessary development tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant