Repository navigation
Fix west installation of scaffold - #8
Conversation
Signed-off-by: Emilio Bottoni <emilio.bottoni@edge.ufal.br>
There was a problem hiding this comment.
Code Review
This pull request updates dependency management by modifying pyproject.toml and requirements.txt, and redirecting the Zephyr module configuration. Feedback identifies duplicated and potentially invalid versioning for the rich library in both dependency files. Additionally, development dependencies like ruff and pytest should be removed from requirements.txt to prevent unnecessary installations for end-users.
| "rich>=13.0", | ||
| "jinja2>=3.1", | ||
| "platformdirs>=4.0", | ||
| "pyyaml>=6.0", | ||
| "jsonschema>=4.18", | ||
| "rich>=15.0", |
There was a problem hiding this comment.
The rich dependency is duplicated at lines 9 and 14. Furthermore, version 15.0 appears to be incorrect as the current stable version of rich is 13.x. This will likely cause installation to fail. Please remove the duplicate and verify the required version.
| "rich>=13.0", | |
| "jinja2>=3.1", | |
| "platformdirs>=4.0", | |
| "pyyaml>=6.0", | |
| "jsonschema>=4.18", | |
| "rich>=15.0", | |
| "rich>=13.0", | |
| "jinja2>=3.1", | |
| "platformdirs>=4.0", | |
| "pyyaml>=6.0", | |
| "jsonschema>=4.18", |
| rich>=13.0 | ||
| jinja2>=3.1 | ||
| platformdirs>=4.0 | ||
| pyyaml>=6.0 | ||
| jsonschema>=4.18 | ||
| rich>=15.0 |
| ruff | ||
| pytest>=8.0 | ||
| pytest |
There was a problem hiding this comment.
Development dependencies (ruff and pytest) should not be included in the main requirements.txt file, as this file is used for the Zephyr module installation via west. These are already defined in the dev section of pyproject.toml. Including them here forces end-users to install unnecessary development tools.
This pull request updates the project's dependencies and configuration files to improve package management and development workflows. The most important changes are grouped below:
Dependency management improvements:
richlibrary as a required dependency inpyproject.toml.devdependency group inpyproject.tomlwithruffandpytestfor development and testing.Build and requirements file updates:
scaffoldtool fromrequirements-west.txt, likely to avoid redundancy or conflicts.zephyr/module.ymlconfiguration to userequirements.txtinstead ofrequirements-west.txtfor pip dependencies, aligning with standard practices.