Skip to content

Fix west installation of scaffold #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MilhoNerfado merged 1 commit into from
May 5, 2026
Merged

Fix west installation of scaffold #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,19 @@ version = "0.1.0"
description = "Zephyr project component scaffolding tool"
requires-python = ">=3.10"
dependencies = [
"typer>=0.12",
"questionary>=2.0",
"rich>=13.0",
"jinja2>=3.1",
"platformdirs>=4.0",
"pyyaml>=6.0",
"jsonschema>=4.18",
"typer>=0.12",
"questionary>=2.0",
"rich>=13.0",
"jinja2>=3.1",
"platformdirs>=4.0",
"pyyaml>=6.0",
"jsonschema>=4.18",
"rich>=15.0",
Comment on lines +9 to +14

@gemini-code-assist gemini-code-assist Bot May 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rich dependency is duplicated at lines 9 and 14. Furthermore, version 15.0 appears to be incorrect as the current stable version of rich is 13.x. This will likely cause installation to fail. Please remove the duplicate and verify the required version.

Suggested change
"rich>=13.0",
"jinja2>=3.1",
"platformdirs>=4.0",
"pyyaml>=6.0",
"jsonschema>=4.18",
"rich>=15.0",
"rich>=13.0",
"jinja2>=3.1",
"platformdirs>=4.0",
"pyyaml>=6.0",
"jsonschema>=4.18",

]

[project.optional-dependencies]
dev = ["ruff", "pytest>=8.0"]

[project.scripts]
scaffold = "scaffold.cli:app"

Expand Down
1 change: 0 additions & 1 deletion requirements-west.txt
View file
Open in desktop

This file was deleted.

12 changes: 10 additions & 2 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
-e .
typer>=0.12
questionary>=2.0
rich>=13.0
jinja2>=3.1
platformdirs>=4.0
pyyaml>=6.0
jsonschema>=4.18
rich>=15.0
Comment on lines +3 to +8

@gemini-code-assist gemini-code-assist Bot May 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rich dependency is duplicated here as well. It is recommended to keep only one entry with the correct version constraint.

rich>=13.0
jinja2>=3.1
platformdirs>=4.0
pyyaml>=6.0
jsonschema>=4.18


ruff
pytest>=8.0
pytest
Comment on lines 10 to +11

@gemini-code-assist gemini-code-assist Bot May 5, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Development dependencies (ruff and pytest) should not be included in the main requirements.txt file, as this file is used for the Zephyr module installation via west. These are already defined in the dev section of pyproject.toml. Including them here forces end-users to install unnecessary development tools.

2 changes: 1 addition & 1 deletion zephyr/module.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ name: scaffold
package-managers:
pip:
requirement-files:
- requirements-west.txt
- requirements.txt
Loading