fix(list-view-card): truncate long descriptions and surface full text…#2
Open
hbrooks wants to merge 1 commit into
Open
fix(list-view-card): truncate long descriptions and surface full text…#2hbrooks wants to merge 1 commit into
hbrooks wants to merge 1 commit into
Conversation
… via tooltip Long localized strings such as 'Geändert vor ungefähr einer Stunde und siebenundzwanzig Minuten' wrap onto multiple lines or get clipped on dashboard/chart/saved-query/tag list cards because the description prop is passed straight through to AntD's Card.Meta with no overflow handling, while the title and titleRight elements in the same component already have ellipsis + tooltip patterns. Add overflow/ellipsis CSS for .ant-card-meta-description on the styled card and wrap the description in the existing Tooltip component so the full localized text remains accessible on hover. No prop signature changes. Fixes apache#40460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally PR apache#40500 in apache/superset by @crimsondhaks