Skip to content

fix(list-view-card): truncate long descriptions and surface full text… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hbrooks wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(list-view-card): truncate long descriptions and surface full text… #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,15 @@ const StyledCard = styled(Card)`
transform: translateY(0);
}
}

/* Truncate long descriptions (e.g. localized "Modified at" timestamps)
so they don't overflow the card. The full value remains accessible
via the tooltip wrapper applied around the description. */
.ant-card-meta-description {
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}
`}
`;

Expand Down Expand Up @@ -258,7 +267,15 @@ function ListViewCard({
</div>
</TitleContainer>
}
description={description}
description={
description ? (
<Tooltip title={description}>
<span>{description}</span>
</Tooltip>
) : (
description
)
}
avatar={avatar || null}
/>
)}
Expand Down