[ios][precompile] fixed issue with xcconfig being overwritten #54838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to change the target xcconfig from within `add_rn_core`, we need to make sure it is not overwritten by the line that sets the config. This commit fixes this by moving it after the line: `spec.pod_target_xcconfig = current_config`
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Expo
Job Summary for GradleTest All :: run_fantom_tests
|
cipolleschi
approved these changes
Dec 10, 2025
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D88849730. |
Contributor
|
/rebase - this comment automatically rebase on top of main |
Contributor
|
automatic rebase failed... @chrfalch could you rebase the stack on top of main, please? |
|
@cipolleschi merged this pull request in 73d3429. |
Collaborator
|
This pull request was successfully merged by @chrfalch in 73d3429 When will my fix make it into a release? | How to file a pick request? |
Collaborator
Author
Is it still required? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To be able to change the target xcconfig from within
add_rn_core, we need to make sure it is not overwritten by the line that sets the config.This commit fixes this by moving it after the line:
spec.pod_target_xcconfig = current_configNext PR: #54839
Changelog:
[IOS] [FIXED] - Moved setting xcconfig to after
add_rn_corepod function is called.Test Plan:
Run RNTester with precompiled binaries.