[ios][precompile] move header template to separate-folder #54839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be able to change the target xcconfig from within `add_rn_core`, we need to make sure it is not overwritten by the line that sets the config. This commit fixes this by moving it after the line: `spec.pod_target_xcconfig = current_config`
A small cleanup to make the directory structure of the header file template when building xcframeworks. Umbrella and module map templates are now moved into templates folder.
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
Job Summary for GradleTest All :: run_fantom_tests
|
cipolleschi
reviewed
Dec 10, 2025
Job Summary for GradleTest All :: run_fantom_tests
|
cipolleschi
changed the base branch from
main
to
chrfalch/react-precompile-fix-order-of-calling-add-rncore-dependency
cipolleschi
requested changes
Dec 16, 2025
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Looks good to me, but I'd put back the < for uikit.
This was referenced Dec 17, 2025
cipolleschi
approved these changes
Dec 17, 2025
cipolleschi
changed the base branch from
chrfalch/react-precompile-fix-order-of-calling-add-rncore-dependency
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small cleanup to make the directory structure of the header file template when building xcframeworks.
Umbrella and module map templates are now moved into a templates folder in the scripts/iOS-prebuilt folder
Prev PR: #54838
Next PR: #54840
Changelog:
[INTERNAL] [FIXED] - Moved iOS prebuild scripts to templates folder.
Test Plan:
Run RNTester with prebuilds