modules: Fix WASM compatibility by guarding Instant::now() calls - #154
Closed
connyay wants to merge 2 commits into
Closed
modules: Fix WASM compatibility by guarding Instant::now() calls#154connyay wants to merge 2 commits into
connyay wants to merge 2 commits into
Conversation
Guard Instant::now() usage in Module::freeze() with cfg(not(target_arch = "wasm32")) to prevent runtime panics on WASM targets. On WASM, eval_duration only tracks evaluation time without freeze timing.
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
This is a bandaid that follows a pattern like 4d32658, but it isn't great and future additions of Instant::now() will continue to break wasm support :-/ like this current open PR #152 connyay@1dbb2de is an alternate to this PR that is a bit more disruptive, but easier to avoid future wasm breakages. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D97677037. (Because this pull request was imported automatically, there will not be any future comments.) |
JakobDegen
approved these changes
Mar 25, 2026
JakobDegen
left a comment
JakobDegen
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in d3f8ea5. |
meta-codesync Bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Mar 25, 2026
Summary: Guard Instant::now() usage in Module::freeze() with cfg(not(target_arch = "wasm32")) to prevent runtime panics on WASM targets. On WASM, eval_duration only tracks evaluation time without freeze timing. X-link: facebook/starlark-rust#154 Reviewed By: JakobDegen Differential Revision: D97677037 fbshipit-source-id: 7fbdcf85a5a61719d6e700d6cf8fb9ae9606f556
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard Instant::now() usage in Module::freeze() with cfg(not(target_arch = "wasm32")) to prevent runtime panics on WASM targets. On WASM, eval_duration only tracks evaluation time without freeze timing.