Skip to content

modules: Fix WASM compatibility by guarding Instant::now() calls #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
connyay wants to merge 2 commits into from
Closed

modules: Fix WASM compatibility by guarding Instant::now() calls #154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a53544d
modules: Fix WASM compatibility by guarding Instant::now() calls
connyay Oct 11, 2025
e45d98e
Merge branch 'facebook:main' into wasm
connyay Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions starlark/src/environment/modules.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,7 @@ impl<'v> Module<'v> {
extra_value,
heap_profile_on_freeze,
} = self;
#[cfg(not(target_arch = "wasm32"))]
let start = Instant::now();
// This is when we do the GC/freeze, using the module slots as roots
// Note that we even freeze anonymous slots, since they are accessed by
Expand Down Expand Up @@ -487,7 +488,10 @@ impl<'v> Module<'v> {
heap: frozen_heap.into_ref_impl(name),
module: frozen_module_ref,
extra_value,
#[cfg(not(target_arch = "wasm32"))]
eval_duration: start.elapsed() + eval_duration.get(),
#[cfg(target_arch = "wasm32")]
eval_duration: eval_duration.get(),
})
}

Expand Down