Refactoring the image building process (CORSIKA/sim_telarray/simtools)

[GernotMaier]

Refactoring the image building process (CORSIKA/sim_telarray/simtools):

• separate images for CORSIKA and sim_telarray
• directory change in images to /workdir/simulation_software/ with e.g.
  • /workdir/simulation_software/corsika
  • /workdir/simulation_software/sim_telarray
• simulation software packages pulled from git repositories
  • CORSIKA7 from KIT gitlab and CORSIKA build configuration from CTAO gitlab
  • sim_telarray, hessio, and stdtools from CTAO gitlab
• new build process for CORSIKA7 using coconut and configuration files

New Docker files / workflows:

1. docker/Dockerfile-corsika7, .github/workflows/build-corsika7.yml: build CORSIKA7 for different opimization using KIT gitlab (no QGSTables included)
2. docker/Dockerfile-simtel_array, .github/workflows/build-sim_telarray.yml: build sim_telarray, hessioxxx, stdools using CTAO gitlab. No CORSIKA included (temporary: hessioxxx from tar package)
3. docker/Dockerfile-simtools-dev, .github/workflows/build-simtools-dev.yml: develop image for simtools include the images build in the steps 1 and 2; QGSJet-III Table added; no_opt build.
4. docker/Dockerfile-simtools-prod, .github/workflows/build-simtools-prod.yml (missing):productions images for simtools (several images for each optimization step; includes images from steps 1 and 2)

Legacy Docker files :

• docker/Dockerfile-corsika-simtel, .github/workflows/build-corsika-simtel.yml : build CORSIKA and sim_telarray using tar packages
• docker/Dockerfile-simtools-legacy, .github/workflows/build-simtools-legacy.yml : simtools production image (includes qgs tables) based on Dockerfile-corsika-simtel images

Open points:

• build-corsika7, build-simtools-dev, build-simtel_array: change push back to manual only
• switch to released versions for the code cloned from gitlab --> issue Setting / release of sim_telarray, hessio, stdtools versions. #1947
• bernloher / iact code is part of CORSIKA7 (released and tested) and part of sim_telarray. In a future step, this should be added to the corsika compilation? Decided to work for now with the CORSIKA7 released version.

EPOS executable is included, but corsika_autoinputs probably needs an update to get it working (issue #1925 )

[orelgueta]

This all looks great. I only made a few comments/questions/suggestions, but none of them is critical.

[GernotMaier]

Thanks @orelgueta - I've added now everything or moved tasks into issues.

Tests / linters fail due to #1941 and need #1939 to be merged - we can wait for that if needed.

Let me know if there is anything else I can do.

[orelgueta]

All good, you can merge before or after fixing the tests, I don't mind.

[ctao-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube