Add SO2 embedding modes and init-conditioned embedding interface for RL#5
Open
ht0324 wants to merge 2 commits intogeometric-intelligence:mainfrom
Open
Add SO2 embedding modes and init-conditioned embedding interface for RL#5ht0324 wants to merge 2 commits intogeometric-intelligence:mainfrom
ht0324 wants to merge 2 commits intogeometric-intelligence:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds SO2 embedding experiment infrastructure for RL and fixes embedding inference to use initial-angle conditioning (matching estimation training behavior).
Changes
rawembed_onlyconcat(raw + embedding)embed_only_so2_h64.yamlembed_only_so2_h128.yamlconcat_so2_h64.yamlconcat_so2_h128.yamlobservation_mode: embed_only.init_posduring inference.rnn_so2_h64.yamlrnn_so2_h128.yamlscripts/train_so2_rnn_hidden_sweep.shValidation
poetry run ruff check articulated/estimation/model.py articulated/rl/agent.py articulated/rl/environment.pybash -n scripts/train_so2_rnn_hidden_sweep.shResults
New comparison file:
logs/rl/comparison/obs_mode_comparison_initcond_20260228_014306.csvSingle-seed ranking (higher is better):
baseline_raw: -3.902concat_h128: -8.234embed_only_h64: -10.167concat_h64: -10.419embed_only_h128: -11.054Notes
Raw baseline still performs best in current runs. Init conditioning improved some embedding variants (notably
concat_h128). Multi-seed confirmation is recommended before final conclusions.