Skip to content

fix(issueList): default row graph period to auto to follow global time range - #124242

Open
parh0m2007 wants to merge 1 commit into
getsentry:masterfrom
parh0m2007:fix/115090-graph-stats-period
Open

parh0m2007 wants to merge 1 commit into
getsentry:masterfrom
parh0m2007:fix/115090-graph-stats-period

Conversation

@parh0m2007

Copy link
Copy Markdown

Problem

The per-row sparkline graphs in the issue list always defaulted to a 24h window, regardless of what was selected in the global time range selector. Users had to manually click the 3d toggle every time they changed the date selector, because the graph did not update along with it (see the issue for a screen recording).

Closes #115090

Solution

Default groupStatsPeriod to 'auto' (which already exists as a supported value: it makes the backend compute stats over the range selected by the global date selector, with an appropriate rollup) instead of hardcoding '24h', when no explicit period is chosen in the URL.

Two changes in static/app/views/issueList/overview.tsx:

  1. DEFAULT_GRAPH_STATS_PERIOD is now 'auto'.
  2. getEndpointParams now sends groupStatsPeriod explicitly whenever it is not '24h' — including when it equals the new default — because the backend (calculate_stats_period) treats a missing groupStatsPeriod as '24h', which would silently undo the new default.

The existing 24h/<selection period> toggles in the Trend column header keep working: the auto toggle is now active by default and the 24h quick-toggle remains available to opt out.

Recipes

  • Reproduce the issue on master — graphs stay at 24h while the header selector says e.g. 14d
  • Apply the fix and verify the graphs follow the global selection
  • Update the affected tests and add a regression test asserting groupStatsPeriod=auto is sent to the API by default

Evidence

PASS static/app/views/issueList/overview.spec.tsx
Tests: 29 passed, 29 total

The request to /organizations/<org>/issues/ now includes groupStatsPeriod=auto by default, so stats come back keyed under 'auto' (computed from start/end derived from the global selection) and are rendered by the existing statsPeriod plumbing end-to-end.

One behavior note for reviewers: because transitionTo serializes endpoint params into the URL query, the URL now shows groupStatsPeriod=auto when no explicit period is chosen. This makes the default shareable/restorable via the URL — the corresponding tests were updated to reflect it.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

…e range

The per-row sparkline graphs in the issue list defaulted to a 24h
window regardless of the global time range selection, so users had to
manually hit the '3d' toggle every time they changed the date selector.

Default groupStatsPeriod to 'auto' so the graphs follow the global
time range selection. 'auto' is sent explicitly to the API because the
backend treats a missing groupStatsPeriod as '24h'.

Fixes getsentry#115090
@parh0m2007
parh0m2007 requested a review from a team as a code owner September 12, 2026 14:52
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The graph on the issues listing page does not match the time-range selector

1 participant