fix(issueList): default row graph period to auto to follow global time range - #124242
Open
parh0m2007 wants to merge 1 commit into
Open
parh0m2007 wants to merge 1 commit into
parh0m2007 wants to merge 1 commit into
Conversation
…e range The per-row sparkline graphs in the issue list defaulted to a 24h window regardless of the global time range selection, so users had to manually hit the '3d' toggle every time they changed the date selector. Default groupStatsPeriod to 'auto' so the graphs follow the global time range selection. 'auto' is sent explicitly to the API because the backend treats a missing groupStatsPeriod as '24h'. Fixes getsentry#115090
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The per-row sparkline graphs in the issue list always defaulted to a 24h window, regardless of what was selected in the global time range selector. Users had to manually click the
3dtoggle every time they changed the date selector, because the graph did not update along with it (see the issue for a screen recording).Closes #115090
Solution
Default
groupStatsPeriodto'auto'(which already exists as a supported value: it makes the backend compute stats over the range selected by the global date selector, with an appropriate rollup) instead of hardcoding'24h', when no explicit period is chosen in the URL.Two changes in
static/app/views/issueList/overview.tsx:DEFAULT_GRAPH_STATS_PERIODis now'auto'.getEndpointParamsnow sendsgroupStatsPeriodexplicitly whenever it is not'24h'— including when it equals the new default — because the backend (calculate_stats_period) treats a missinggroupStatsPeriodas'24h', which would silently undo the new default.The existing
24h/<selection period>toggles in the Trend column header keep working: theautotoggle is now active by default and the24hquick-toggle remains available to opt out.Recipes
master— graphs stay at 24h while the header selector says e.g. 14dgroupStatsPeriod=autois sent to the API by defaultEvidence
The request to
/organizations/<org>/issues/now includesgroupStatsPeriod=autoby default, so stats come back keyed under'auto'(computed fromstart/endderived from the global selection) and are rendered by the existingstatsPeriodplumbing end-to-end.One behavior note for reviewers: because
transitionToserializes endpoint params into the URL query, the URL now showsgroupStatsPeriod=autowhen no explicit period is chosen. This makes the default shareable/restorable via the URL — the corresponding tests were updated to reflect it.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.