Skip to content

fix(issueList): default row graph period to auto to follow global time range #124242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parh0m2007 wants to merge 1 commit into
base: master
Choose a base branch
from
+42 −4
Open

fix(issueList): default row graph period to auto to follow global time range #124242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion static/app/views/issueList/overview.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ describe('IssueList', () => {
await waitFor(() => {
expect(testRouter.location.query).toEqual({
cursor: '1443575000:0:0',
groupStatsPeriod: 'auto',
page: '1',
project: '3559',
query: DEFAULT_QUERY,
Expand All @@ -364,6 +365,7 @@ describe('IssueList', () => {
await waitFor(() => {
expect(testRouter.location.query).toEqual({
cursor: '1443574000:0:0',
groupStatsPeriod: 'auto',
page: '2',
project: '3559',
query: DEFAULT_QUERY,
Expand All @@ -378,6 +380,7 @@ describe('IssueList', () => {
await waitFor(() => {
expect(testRouter.location.query).toEqual({
cursor: '1443575000:0:1',
groupStatsPeriod: 'auto',
page: '1',
project: '3559',
query: DEFAULT_QUERY,
Expand Down Expand Up @@ -512,6 +515,7 @@ describe('IssueList', () => {

await waitFor(() => {
expect(testRouter.location.query).toEqual({
groupStatsPeriod: 'auto',
project: project.id.toString(),
query: 'is:ignored',
statsPeriod: '14d',
Expand Down Expand Up @@ -632,7 +636,39 @@ describe('IssueList', () => {
expect(fetchDataMock).toHaveBeenLastCalledWith(
'/organizations/org-slug/issues/',
expect.objectContaining({
data: 'collapse=stats&collapse=unhandled&expand=owners&expand=inbox&limit=25&project=99&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&shortIdLookup=1&statsPeriod=14d',
data: 'collapse=stats&collapse=unhandled&expand=owners&expand=inbox&groupStatsPeriod=auto&limit=25&project=99&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&shortIdLookup=1&statsPeriod=14d',
})
);
});
});

it('defaults the row graph period to auto so it follows the global time range', async () => {
const {rerender} = render(<IssueListOverview />, {
initialRouterConfig: merge({}, initialRouterConfig, {
location: {
query: {
query: DEFAULT_QUERY,
},
},
}),
});

act(() =>
PageFiltersStore.onInitializeUrlState({
projects: [99],
environments: [],
datetime: {period: '14d', start: null, end: null, utc: null},
})
);

rerender(<IssueListOverview />);

await waitFor(() => {
expect(fetchDataMock).toHaveBeenNthCalledWith(
2,
'/organizations/org-slug/issues/',
expect.objectContaining({
data: 'collapse=stats&collapse=unhandled&expand=owners&expand=inbox&groupStatsPeriod=auto&limit=25&project=99&query=is%3Aunresolved%20issue.priority%3A%5Bhigh%2C%20medium%5D&shortIdLookup=1&statsPeriod=14d',
})
);
});
Expand Down
8 changes: 5 additions & 3 deletions static/app/views/issueList/overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@ import {
} from './utils';

const MAX_ITEMS = 25;
// the default period for the graph in each issue row
const DEFAULT_GRAPH_STATS_PERIOD = '24h';
// the allowed period choices for graph in each issue row
const DYNAMIC_COUNTS_STATS_PERIODS = new Set(['14d', '24h', 'auto']);
// when no explicit period is chosen, follow the global time range selector
const DEFAULT_GRAPH_STATS_PERIOD = 'auto';
const MAX_ISSUES_COUNT = 100;

interface Props {
Expand Down Expand Up @@ -272,7 +272,9 @@ function IssueListOverviewInner({
}

const groupStatsPeriod = getGroupStatsPeriod();
if (groupStatsPeriod !== DEFAULT_GRAPH_STATS_PERIOD) {
// The backend treats a missing groupStatsPeriod as '24h', so 'auto'
// (follow the global time range) has to be sent explicitly.
if (groupStatsPeriod !== '24h') {
params.groupStatsPeriod = groupStatsPeriod;
}

Expand Down
Loading